It appears that the PEP8 rules has been updated since the release of PEP8 1.4.6, the version on CentOS 7. This causes the build and test cases to fail.
These are the errors displayed as of the latest master branch today. Here's what happens when you attempt to make the project:
[root@ipsilon12 ipsilon]# make # Determine if test deps are installed # First, some binaries which pylint /bin/pylint which pep8 /bin/pep8 which httpd /sbin/httpd which postgres /bin/postgres which openssl /bin/openssl which slapd /sbin/slapd # Now, python libraries python -c 'import argparse' python -c 'import requests_kerberos' python -c 'import openid' python -c 'import openid_teams' python -c 'import openid_cla' python -c 'import cherrypy' python -c 'import M2Crypto' python -c 'import lasso' python -c '__requires__ = ["sqlalchemy >= 0.8"]; import pkg_resources; import sqlalchemy' python -c 'import ldap' python -c 'import pam' python -c 'import fedora' python -c 'import ipapython' python -c 'import jinja2' python -c 'import psycopg2' # And now everything else ls /usr/lib*/security/pam_sss.so /usr/lib64/security/pam_sss.so ls /usr/lib*/libsss_simpleifp.so.0 /usr/lib64/libsss_simpleifp.so.0 ls /usr/lib*/httpd/modules/mod_wsgi.so /usr/lib64/httpd/modules/mod_wsgi.so ls /usr/libexec/mod_auth_mellon mellon_create_metadata.sh # Analyze code # don't show recommendations, info, comments, report # W0613 - unused argument # Ignore cherrypy class members as they are dynamically added # Ignore IPA API class members as they are dynamically added pylint -d c,r,i,W0613 -r n -f colorized \ --notes= \ --ignored-classes=cherrypy,API \ --disable=star-args \ ./ipsilon No config file found, using default configuration # Check style consistency pep8 ipsilon ipsilon/info/infosssd.py:178:29: E126 continuation line over-indented for hanging indent ipsilon/info/infosssd.py:266:52: E126 continuation line over-indented for hanging indent ipsilon/login/authform.py:16:9: E126 continuation line over-indented for hanging indent ipsilon/providers/openidc/auth.py:707:17: E126 continuation line over-indented for hanging indent make: *** [pep8] Error 1
Here's what happens when you try to make test:
[root@ipsilon12 ipsilon]# make test pylint -d c,r,i,W0613 -r n -f colorized \ --notes= \ --ignored-classes=cherrypy \ --disable=star-args \ ./tests No config file found, using default configuration pep8 --ignore=E121,E123,E126,E226,E24,E704,E402 tests tests/testgssapi.py:43:13: E127 continuation line over-indented for visual indent make: *** [lp-test] Error 1
@puiterwijk does not think that disabling these rules entirely is a good idea, as they work on later versions of PEP8
Include pep8 version 1.7 from pip in the tests directory include-pep8.patch
The patch seems to fix the issues, but per my conversation with @puiterwijk, a more flexible code style checker is probably a better option.
Fields changed
cc: => daniel.theisen@foresee.com milestone: => Backlog owner: => puiterwijk patch_available: 0 => 1 status: new => assigned
Metadata Update from @dtheisen: - Issue assigned to puiterwijk - Issue set to the milestone: Backlog - Issue tagged with: build, compile, error, fail, pep8, test
Log in to comment on this ticket.