We error out at plugin.py of initialization when the file config is used.
This is too hard an error and prevent OpenID from working.
status: new => accepted
Patch and testcase in https://pagure.io/ipsilon/pull-request/77
patch_available: 0 => 1
The error here is that _get_plugin_obj fails if it's used when fileconfig is used.
This is a problem because ipsilon/root.py uses _get_plugin_obj to get a reference to the currently active providers.
This means that if file-based config is used, the main page will not function since root.py will try to get a list of providers (def root():), call to _get_plugin_obj, which errors out because read-only config is used.
The error raised is:
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/cherrypy/_cprequest.py", line 656, in respond
response.body = self.handler()
File "/usr/lib/python2.7/site-packages/cherrypy/lib/encoding.py", line 188, in __call__
self.body = self.oldhandler(*args, **kwargs)
File "/usr/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 34, in __call__
return self.callable(*self.args, **self.kwargs)
File "/home/rcrit/redhat/reviews/pagure/testdir/fconf/lib/idp1/ipsilon/util/page.py", line 91, in __call__
return op(*args, **kwargs)
File "/home/rcrit/redhat/reviews/pagure/testdir/fconf/lib/idp1/ipsilon/root.py", line 57, in root
obj = self.admin.providers._get_plugin_obj(plugin)
File "/home/rcrit/redhat/reviews/pagure/testdir/fconf/lib/idp1/ipsilon/admin/common.py", line 254, in _get_plugin_obj
AdminError: Configuration is marked Read-Only
This has been fixed in 7f76c76.
resolution: => fixed
status: accepted => closed
Metadata Update from @puiterwijk:
- Issue assigned to puiterwijk
- Issue set to the milestone: 1.2
to comment on this ticket.