#193 Incorrect attribute used in logout error message
Closed: Fixed None Opened 3 years ago by rcritten.

Got a traceback while testing Shibboleth logout:

HTTP Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/cherrypy/_cprequest.py", line 670, in respond
    response.body = self.handler()
  File "/usr/lib/python2.7/site-packages/cherrypy/lib/encoding.py", line 217, in __call__
    self.body = self.oldhandler(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/cherrypy/_cpdispatch.py", line 61, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/site-packages/ipsilon/util/page.py", line 91, in __call__
    return op(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/ipsilon/providers/common.py", line 90, in root
    return op(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/ipsilon/providers/saml2idp.py", line 143, in GET
    samlresponse=response)
  File "/usr/lib/python2.7/site-packages/ipsilon/providers/saml2/logout.py", line 303, in logout
    message = self._soap_logout(logout)
  File "/usr/lib/python2.7/site-packages/ipsilon/providers/saml2/logout.py", line 201, in _soap_logout
    (response.status, logout.msgUrl))
AttributeError: 'Response' object has no attribute 'status'

It is a one-liner fix. It should be at least response.status_code but maybe it should include reason as well.


Fields changed

owner: => rcritten
status: new => accepted

master: 2d4e7a1

resolution: => fixed
status: accepted => closed

Metadata Update from @rcritten:
- Issue assigned to rcritten
- Issue set to the milestone: 1.2

2 years ago

Login to comment on this ticket.

Metadata