#167 lasso ECP support check should be based on lasso symbol rather than lasso version
Closed: Fixed None Opened 6 years ago by jdennis.

The function is_lasso_ecp_enabled() in saml2idp.py was testing for a specific lasso version. That has proved problematic because we've had too many "unofficial" versions floating around and sometimes the version check produces the wrong result.

A better test, as was discussed in the team meeting is to test for the presence of a symbol in the lasso library we know will only be there with full ECP support.

Fields changed

owner: => jdennis
status: new => assigned

PR https://pagure.io/ipsilon/pull-request/37

master: 90b8387

milestone: => 1.2
patch_available: 0 => 1
resolution: => fixed
status: assigned => closed

Metadata Update from @rcritten:
- Issue assigned to jdennis
- Issue set to the milestone: 1.2

5 years ago

Login to comment on this ticket.