From efbb1fa8f2e5b838efd36e28848d386b1670d0e3 Mon Sep 17 00:00:00 2001
From: Hunor Csomortáni <csomh@redhat.com>
Date: Nov 30 2022 14:11:32 +0000
Subject: Turn autocomplete off for the OTP field on login forms


One-time passwords are one-time :-) so there is no point in remembering
past values and offering them during subsequent logins.

Similar to:
https://github.com/fedora-infra/noggin/blob/82306f4fcbd1caef517d3379a3d3eb12ff06d6ff/noggin/templates/_login_form.html#L12

Signed-off-by: Hunor Csomortáni <csomh@redhat.com>

---

diff --git a/templates/login/form.html b/templates/login/form.html
index eea8a13..9d75024 100644
--- a/templates/login/form.html
+++ b/templates/login/form.html
@@ -33,7 +33,7 @@
     </div>
     <div class="form-group">
       <div class="col-sm-10 col-md-10 col-sm-offset-2 col-md-offset-2">
-        <input type="text" class="form-control" name="login_otp" id="otp" placeholder="One-Time-Password (if you have one)" tabindex="3" />
+        <input type="text" class="form-control" name="login_otp" id="otp" autocomplete="off" placeholder="One-Time-Password (if you have one)" tabindex="3" />
       </div>
     </div>
     <div class="form-group">
diff --git a/themes/Fedora/templates/login/form.html b/themes/Fedora/templates/login/form.html
index 6c695ab..a340419 100644
--- a/themes/Fedora/templates/login/form.html
+++ b/themes/Fedora/templates/login/form.html
@@ -23,7 +23,7 @@
                         <input class="form-control" id="password" name="login_password" type="password" placeholder="Password" />
                     </div>
                     <div class="form-group mb-0">
-                        <input class="form-control" id="otp" name="login_otp" placeholder="One-Time-Password (if you have one)" />
+                        <input type="text" class="form-control" id="otp" name="login_otp" autocomplete="off" placeholder="One-Time-Password (if you have one)" />
                     </div>
                 </div>
                 <div class="card-footer d-flex justify-content-between">
diff --git a/themes/openSUSE/templates/login/form.html b/themes/openSUSE/templates/login/form.html
index 3630978..2abd7c8 100644
--- a/themes/openSUSE/templates/login/form.html
+++ b/themes/openSUSE/templates/login/form.html
@@ -32,7 +32,7 @@
                         </div>
                         <div class="form-group mb-0">
                             <label for="otp">One-Time-Password</label>
-                          <input class="form-control" id="otp" name="login_otp" placeholder="One-Time-Password (if you have one)" />
+                          <input type="text" class="form-control" id="otp" name="login_otp" autocomplete="off" placeholder="One-Time-Password (if you have one)" />
                         </div>
                     </div>
                     <div class="card-footer d-flex justify-content-between align-items-center">