From 926229277308064f82a87b03cd86fa50c85dc906 Mon Sep 17 00:00:00 2001 From: Patrick Uiterwijk Date: Oct 14 2015 13:15:38 +0000 Subject: Add check for permissions on deleting a SAML2 Service Provider Fixes: #194 Fixes: CVE-2015-5301 Signed-off-by: Patrick Uiterwijk Reviewed-by: Rob Crittenden --- diff --git a/ipsilon/providers/saml2/admin.py b/ipsilon/providers/saml2/admin.py index 811af9f..aa07961 100644 --- a/ipsilon/providers/saml2/admin.py +++ b/ipsilon/providers/saml2/admin.py @@ -254,6 +254,9 @@ class SPAdminPage(AdminPage): message_type=message_type) def delete(self): + if (not self.user.is_admin and + self.user.name != self.sp.owner): + raise cherrypy.HTTPError(403) self.parent.del_sp(self.sp.name) self.sp.permanently_delete() return self.parent.root()