|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is just an example, it seems gratuitous to change it. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This reads to me as if the | ||
|
||
linuxmodder commented 7 years ago That is in fact the only time it is used, for a proper UEFI system gpt is already in place. | ||
immanetize commented 7 years ago The object of your sentence is not clear, it needs to be stated differently. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is good info to add here, but the grammar could be more clear. Can you please restructure this sentence? | ||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This option has a different default behavior depending on the available memory, and we're describing the behavior and how to change it in each circumstance equally. I don't think removing the clause for disabling the default where <2GB of memory is available adds value here. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago We're linking to the docs for kdump in both kickstart and GUI processes, we should stick to describing kdump's function and parameters there. | ||
|
||
linuxmodder commented 7 years ago So link only to the kdump section, and drop the ks link, with a bit more 'why would I use / need to use this' ? | ||
immanetize commented 7 years ago No, don't make changes to this line at all. This is only a list of kickstart options, and kickstart itself is documented elsewhere. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago oops :) | ||
|
||
linuxmodder commented 7 years ago So a 'nothing to see here, move along' ? | ||
immanetize commented 7 years ago Remove '<F12><F12><F12>' . I'm assuming it's an accident. | ||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago GRUB gives you the option of both a function key and ctl+x to boot; in my experience, ctl+x works universally but the function key does not on some systems. ctl+x also aligns with the downstream RHEL Installation Guide. | ||
|
||
linuxmodder commented 7 years ago Never seen or used the Ctl+X myself but sure, not sure the RHEL part should really dictate our docs that much tho tbh. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago A good addition, but a few thoughts on presentation:
| ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago I wouldn't qualify an "Are you sure you want swap?" type message with blocking filesystem layout error messages, to the point that I actually had to reread this several times to get what you were communicating. This should be rephrased to be more clear, or maybe even just left as is. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Good addition! DocBook also has a <keycombo> tag you can use to wrap a set of <keycap> tags, but it isn't imperative. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago I actually prefer the brevity you've added to this sentence, but I don't think we should make this change for a different reason. The change is minor and doesn't affect what the sentence communicates, but the act of changing it will require all translations of the sentence be performed again. It adds a deceptively large amount of work for such a small change. | ||
|
||
linuxmodder commented 7 years ago It seems to read better with the brevity, hence I question if the l10n hit might be worth it on this one. | ||
immanetize commented 7 years ago I agree that it reads better, but no, it isn't worth it. You're asking at least one and probably two people from each of dozens of language teams to review and and translate the string, there isn't enough value in the added brevity to justify that. | ||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago brevity vs l10n team effort concerns apply here too. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago I don't see thinp as 'experimental' at this point. Is there a reference we can cite here? | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is a good point to add, but I think we can be more positive in delivery. It would be best to have an article, list discussion, or document to point to , ie "For information on the features and limitations of btrfs, refer to..." and implicitly recommend that the reader make a decision for themselves. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Because we're working with XML, the '<' character should be represented with it's entity, <'. There's a list of such things and more info at http://www.docbook.org/tdg/en/html/ch01.html#s-entities . | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago hmm... this could be made more succinct if you clarified in the first sentence that XFS cannot be shrunk, only grown. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago how about ..."or if you use a debug kernel, as debug symbols" ? It might be nice to give a rough estimate too, do you know how much space is consumed with the default (installonly_limit) number of debug kernels installed? | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Now that you bring attention to it, I think the technology has progressed to the point that we can defer with this recommendation. Since changing this would require retranslation, I think it would be better to research the validity of the recommendation before changing the copy. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Good catch! We could save some reading time by mentioning /boot/efi with /boot, instead of adding a new paragraph. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago I'm wary of describing the default value here; If you use the installer you'll discover the info on your own, and if we cite that here we'll have to verify the citation for every release. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago s/luie/lieu/ , and there's an open parenthesis without it's close. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Typo here, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a <note> admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic. | ||
immanetize commented 7 years ago Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a <note> admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This section describes interacting with a tmux window, your edits to the keycombos are incorrect and should be reverted. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This entire statement seems incorrect - doesn't the installer ask you about language and layout before anything else, continue the installation using those settings, and install a system with the same settings? | ||
|
||
linuxmodder commented 7 years ago Just noticed that will fix it up. It's totally outdated. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This file isn't actually published to the site, it's used by anaconda for inline help. We keep it in this repo because other content overlaps, and anacondas help files are generated from the installation guide. In that context, it doesn't make sense to make this change, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist? | ||
immanetize commented 7 years ago Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist? | ||
|
||
linuxmodder commented 7 years ago auto does not auto select a value anymore, except on server. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is mostly a general observation that memory constraints have a performance impact, I don't think we need to make that observation here. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago We don't need to point out that the UI element that is highlighted when the dialog opens will be the option chosen unless specified otherwise. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This change doesn't merit retranslation, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is just whitespace added to the end of the line, I think. Not a big problem or a blocker to a merge, but as a practice you should be careful about leaking superfluous changes into your commits. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago
| ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This set of changes serves no purpose, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago The | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is a duplicate pair of lines, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago We have an entire section describing partition layout, I don't think this paragraph needs to get into it. I'm also not confident that | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago inst.commandline and inst.text are still interactive methods; if the prompt is not presented to the user, that is a bug. Have you verified this behavior? I do like an admonition to remind readers that a passphrase declaration is required for an unattended install, though. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago We could more succinctly discuss the backup passphrase with the regular passphrase, and there are some xml validity issues here that would also go away if both were in the same admonition. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Do you have a technical justification for removing the aes-cbc-essiv:sha256 recommendation? | ||
|
||
linuxmodder commented 7 years ago Yes, New standard no longer uses defaults to using cbc | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago I still see the code for this option in anaconda, do you have a technical reference for removing this list entry? | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago revert removing lines 162-195 please. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago revert removing lines 204-213 please. | ||
|
||
|
||
|
||
immanetize commented 7 years ago this breaks xml validity, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago We already said that here. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
linuxmodder commented 7 years ago For most 'advanced' ciphers mcrypt + bcrypt are needed (not included in the default LIves OR kickstarts) | ||
immanetize commented 7 years ago Is there a technical justification for removing the aes-cbc-essiv:sha256 recommendation? Did you intend to describe requirements and reasons to use ciphers that are not supported by the installation image here? | ||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This breaks XML and logical document structure by removing the variable part of a varlistentry, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is good info to add, but your change could be rephrased to be more clear and remove spelling errors. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is more of a rephrasing for personal preference than an improvement; while this usage of 'an' has fallen out of favor in American English, it is still valid, Please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago typo, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago We're losing some of the copy's utility here; you've removed the part that explains to the reader how to make the --autoscreenshot option useful. Unless there's a technical change to the option, please revert. | ||
|
||
linuxmodder commented 7 years ago first off its already explained here: sect-kickstart-commands-installation-environment | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago this admonition is still valid, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This info is valid and appropriate, please revert it's removal. | ||
|
||
linuxmodder commented 7 years ago It's already thrice mentioned previously . | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This breaks XML; if the kickstart option is no longer valid, you should only remove the <varlistentry> block. If it is deprecated, can you please cite a reference? It's usually best to make such references in a commit message. | ||
|
||
linuxmodder commented 7 years ago Notably IBM Systems, this is a RHEL use case NOT Fedora.... | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This info is valid, please revert it's removal. | ||
|
||
linuxmodder commented 7 years ago Don't see need for a redundant mention of same commands shown just below it . It's akin to a nag bomb. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
linuxmodder commented 7 years ago Needless redirects could still be removed | ||
immanetize commented 7 years ago The information is accurate and inappropriate; I don't know what you mean by 'redirect' in this context, or why you are removing these lines. | ||
immanetize commented 7 years ago ...appropriate. It is not inappropriate information. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago s390 Fedora does exist, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Can you provide a reference showing the kexec option has been removed from anaconda? | ||
|
||
linuxmodder commented 7 years ago Per chat in #anaconda, team stated its mostly for RHEL NOT Fedora and is discouraged. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago Anaconda plugins are a real thing, please revert removing this section. | ||
|
||
linuxmodder commented 7 years ago Again was advised this was mostly RHEL NOT Fedora | ||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is an unnecessary change, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This is an unnecessary change, please revert. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago I'm going to defer to Petr on removing or using this warning; this change is a good example of why smaller pull requests are better. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
immanetize commented 7 years ago This would be better as a <simplelist> or <itemizedlist>; it will get formatted more appropriately that way. | ||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
|
||
Appending to the end here, after the 'or', makes it read as if USB drives are an example of a network location. How about ~"an ISO image.... on either optical or USB disk?"