#1 Basic Edits (Most File edits included -- 6 Files remain)
Closed 7 years ago by immanetize. Opened 7 years ago by linuxmodder.
linuxmodder/install-guide master  into  master

Edits
linux-modder • 7 years ago  
Edits
linux-modder • 7 years ago  
Basic edits
linux-modder • 7 years ago  
Basic Review
linux-modder • 7 years ago  
file modified
+1 -1
@@ -20,7 +20,7 @@ 

  	<title>Installation Guide</title>

  	<subtitle>Installing &PRODUCT;&nbsp;&PRODVER; on 32 and 64-bit AMD and Intel</subtitle>

  	<productname>Fedora</productname>

- 	<productnumber>23</productnumber>

+ 	<productnumber>24</productnumber>

  	<edition>1</edition>

    <pubsnumber>0</pubsnumber>

    <subjectset>

file modified
+17 -31
@@ -74,7 +74,7 @@ 

  							</listitem>

  							<listitem>

  								<para>

- 									an ISO image of the full &PRODUCT; installation DVD, placed on a hard drive or a network location accessible from the installation system

+ 									an ISO image of the full &PRODUCT; installation DVD, placed on a hard drive or a network location accessible from the installation system, including USB Drives.

Appending to the end here, after the 'or', makes it read as if USB drives are an example of a network location. How about ~"an ISO image.... on either optical or USB disk?"

  								</para>

  							</listitem>

  						</itemizedlist>
@@ -107,7 +107,7 @@ 

  									</row>

  									<row>

  										<entry>

- 											Specific CD/DVD drive

+ 											Specific CD/DVD drive/USB Drive

  										</entry>

  										<entry>

  											<option>inst.repo=cdrom:<replaceable>device</replaceable></option>
@@ -172,7 +172,7 @@ 

  							</listitem>

  							<listitem>

  								<para>

- 									File system label, for example <systemitem>LABEL=Flash</systemitem> or <systemitem>LABEL=RHEL7</systemitem>

+ 									File system label, for example <systemitem>LABEL=Flash</systemitem> or <systemitem>LABEL=FEDORA\x2024</systemitem>

  								</para>

  							</listitem>

  							<listitem>
@@ -211,7 +211,7 @@ 

  						</para>

  						<important>

  							<para>

- 								You should never attempt to perform a driver update during the installation unless a missing our faulty driver is preventing you from completing the installation. Updating drivers which are not essential during the installation should always be performed after the system is installed.

+ 								You should never attempt to perform a driver update during the installation unless a missing or faulty driver is preventing you from completing the installation. Updating drivers which are not essential during the installation should always be performed after the system is installed.

  							</para>

  						</important>

  					</listitem>
@@ -335,7 +335,7 @@ 

  					<term><option>inst.lang=</option></term>

  					<listitem>

  						<para>

- 							Sets the language to be used during the installation. Language codes are the same as the ones used in the <command>lang</command> Kickstart command as described in <xref linkend="sect-kickstart-commands-lang" />. On systems where the <package>system-config-language</package> package is installed, a list of valid values can also be find in <filename>/usr/share/system-config-language/locale-list</filename>.

+ 							Sets the language to be used during the installation. Language codes are the same as the ones used in the <command>lang</command> Kickstart command as described in <xref linkend="sect-kickstart-commands-lang" />. On systems where the <package>system-config-language</package> package is installed, a list of valid values can also be found in <filename>/usr/share/system-config-language/locale-list</filename>.

  						</para>

  						<para>

  							If you perform the installation interactively, the language you specified using this option will be selected by default, but you will still be able to change it at the beginning of the graphical installation.
@@ -656,9 +656,9 @@ 

  						<para>

  							Sets up a Virtual LAN (VLAN) device on a specified interface with a given name. The syntax is <option>vlan=<replaceable>name</replaceable>:<replaceable>interface</replaceable></option>. For example:

  						</para>

- 						<screen><option>vlan=vlan5:em1</option></screen>

+ 						<screen><option>vlan=vlan1:em1</option></screen>

This is just an example, it seems gratuitous to change it.

  						<para>

- 							The above will set up a VLAN device named <literal>vlan5</literal> on the <literal>em1</literal> interface. The <replaceable>name</replaceable> can take the following forms:

+ 							The above will set up a VLAN device named <literal>vlan1</literal> on the <literal>em1</literal> interface. The <replaceable>name</replaceable> can take the following forms:

  						</para>

  						<table id="tabl-boot-options-network-vlan-names">

  							<title>VLAN Device Naming Conventions</title>
@@ -681,7 +681,7 @@ 

  											VLAN_PLUS_VID

  										</entry>

  										<entry>

- 											<literal>vlan0005</literal>

+ 											<literal>vlan.0001</literal>

  										</entry>

  									</row>

  									<row>
@@ -689,7 +689,7 @@ 

  											VLAN_PLUS_VID_NO_PAD

  										</entry>

  										<entry>

- 											<literal>vlan5</literal>

+ 											<literal>vlan1</literal>

  										</entry>

  									</row>

  									<row>
@@ -697,7 +697,7 @@ 

  											DEV_PLUS_VID

  										</entry>

  										<entry>

- 											<literal>em1.0005</literal>.

+ 											<literal>em1.0001</literal>.

  										</entry>

  									</row>

  									<row>
@@ -705,7 +705,7 @@ 

  											DEV_PLUS_VID_NO_PAD

  										</entry>

  										<entry>

- 											<literal>em1.5</literal>.

+ 											<literal>em1.1</literal>.

  										</entry>

  									</row>

  								</tbody>
@@ -761,7 +761,7 @@ 

  					<term><option>inst.gpt</option></term>

  					<listitem>

  						<para>

- 							Force the installation program to install partition information into a GUID Partition Table (GPT) instead of a Master Boot Record (MBR). This option is meaningless on UEFI-based systems, unless they are in BIOS compatibility mode.

+ 							Force the installation program to install partition information into a GUID Partition Table (GPT) instead of a Master Boot Record (MBR). This option is meaningless on UEFI-based systems, unless they are in BIOS compatibility mode. Commonly (marked as <literal>UEFI+CSM</literal> or (marked as <literal>LEGACY</literal>)).

This reads to me as if the inst.gpt option is commonly marked as UEFI+CSM or LEGACY. Can you restructure this?

  						</para>

That is in fact the only time it is used, for a proper UEFI system gpt is already in place.

The object of your sentence is not clear, it needs to be stated differently.

  						<para>

  							Normally, BIOS-based systems and UEFI-based systems in BIOS compatibility mode will attempt to use the MBR schema for storing partitioning information, unless the disk is larger than 2 TB. Using this option will change this behavior, allowing a GPT to be written even to disks smaller than 2 TB.
@@ -775,10 +775,10 @@ 

  					<term><option>inst.zram</option></term>

  					<listitem>

  						<para>

- 							This option controls the usage of <firstterm>zRAM</firstterm> swap during the installation. It creates a compressed block device inside the system RAM and uses it for swap space instead of the hard drive. This allows the installer to essentially increase the amount of memory available, which makes the installation faster on systems with low memory.

+ 							This option controls the usage of <firstterm>zRAM</firstterm> swap during the installation. It creates a compressed block device inside the system RAM and uses it for swap space instead of the hard drive. This allows the installer to essentially increase the amount of memory available, which makes the installation faster on systems with low memory. This will inherit to the installed system as well, however in disable state on systemc with > 2G RAM

This is good info to add here, but the grammar could be more clear. Can you please restructure this sentence?

  						</para>

  						<para>

- 							By default, swap on zRAM is enabled on systems with 2 GB or less RAM, and disabled on systems with more than 2 GB of memory. You can use this option to change this behavior - on a system with more than 2 GB RAM, use <option>inst.zram=1</option> to enable it, and on systems with 2 GB or less memory, use <option>inst.zram=0</option> to disable this feature.

+ 							By default, swap on zRAM is enabled on systems with 2 GB or less RAM, and disabled on systems with more than 2 GB of memory. You can use this option to change this behavior - on a system with more than 2 GB RAM, use <option>inst.zram=1</option> to enable it.

This option has a different default behavior depending on the available memory, and we're describing the behavior and how to change it in each circumstance equally. I don't think removing the clause for disabling the default where <2GB of memory is available adds value here.

  						</para>

  					</listitem>

  				</varlistentry>
@@ -802,7 +802,7 @@ 

  					<term><option>inst.kdump_addon=</option></term>

  					<listitem>

  						<para>

- 							Turns the <application>Kdump</application> installer add-on <literal>on</literal> or <literal>off</literal> (the add-on is off by default). If you use <option>inst.kdump_addon=on</option>, a new screen, which allows you to configure the <application>Kdump</application> kernel crash dumping mechanism, will appear in the main menu of the graphical or text interface (see <xref linkend="sect-installation-gui-kdump" />). Enabling this add-on is also necessary to use the <xref linkend="sect-kickstart-commands-kdump" /> Kickstart command.

+ 							Turns the <application>Kdump</application> installer add-on <literal>on</literal> or <literal>off</literal> (the add-on is off by default). If you use <option>inst.kdump_addon=on</option>, a new screen, which allows you to configure the <application>Kdump</application> kernel crash dumping mechanism, will appear in the main menu of the graphical or text interface, default kdump store is  128Mb. (see <xref linkend="sect-installation-gui-kdump" />). Enabling this add-on is also necessary to use the <xref linkend="sect-kickstart-commands-kdump" /> Kickstart command.

We're linking to the docs for kdump in both kickstart and GUI processes, we should stick to describing kdump's function and parameters there.

  						</para>

So link only to the kdump section, and drop the ks link, with a bit more 'why would I use / need to use this' ?

No, don't make changes to this line at all. This is only a list of kickstart options, and kickstart itself is documented elsewhere.

  					</listitem>

  				</varlistentry>
@@ -884,7 +884,7 @@ 

  					<term><option>inst.syslog=</option></term>

  					<listitem>

  						<para>

- 							Once the installation starts, this option sends log messages to the syslog process on the specified host. The remote syslog process must be configured to accept incoming connections. <!-- TODO: Where do we document remote logging? -->

+ 							Once the installation starts, this option sends log messages to the syslog process on the specified host. The remote syslog process must be configured to accept incoming connections. <ulink url=https://fedoraproject.org/wiki/Anaconda/Logging/>

  						</para>

  					</listitem>

  				</varlistentry>
@@ -1024,16 +1024,6 @@ 

  								</row>

  							</tbody>

  						</tgroup>

- 					</table>

- 					<important> <!-- TODO: check BZ#1085310 -->

- 						<para>

- 							When performing a Kickstart installation, booting from local media and having the Kickstart file on local media as well, the network will not be initialized. This means that any other Kickstart options requiring network access, such as pre-installation or post-installation scripts accessing a network location, will cause the installation to fail. This is a known issue; see BZ#<ulink url="https://bugzilla.redhat.com/show_bug.cgi?id=1085310">1085310</ulink> for details.

- 						</para>

- 						<para>

- 							To work around this issue, either use the <option>ksdevice=link</option> boot option, or add the <option>--device=link</option> option to the <command>network</command> command in your Kickstart file.

- 						</para>

- 					</important>

- 				</listitem>

  			</varlistentry>

  			<varlistentry>

  				<term><option>blacklist=</option></term>
@@ -1187,11 +1177,7 @@ 

  			<para>

  				&PRODUCT; includes the <application>Memtest86+</application> memory testing application. To start memory testing mode, choose <guisubmenu>Troubleshooting</guisubmenu> &gt; <guimenuitem>Memory test</guimenuitem> at the boot menu. Testing will begin immediately. By default, <application>Memtest86+</application> carries out ten tests in every pass; a different configuration can be specified by accessing the configuration screen using the <keycap>c</keycap> key. After the first pass completes, a message will appear at the bottom informing you of the current status, and another pass will start automatically.

  			</para>

- 			<note>

- 				<para>

- 					<application>Memtest86+</application> only works on systems with BIOS firmware. Support for UEFI systems is currently unavailable.

- 				</para>

- 			</note>

+ 

  			<figure>

  				<title>Memory Check Using Memtest86+</title>

  				<mediaobject>

@@ -50,7 +50,7 @@ 

  						Some older systems may not support choosing a boot device at startup. In that case, enter the system's SETUP (BIOS), and change the default boot order so that your boot media (CD, DVD, USB or network) has higher priority than internal hard drives.

  					</para>

  					<para>

- 						On Mac hardware, hold down the <keycap>Option</keycap> key to enter the boot media selection menu.

+ 						On Mac hardware, hold down the <keycap>Option</keycap> <keycap>C</keycap> keys to enter the boot media selection menu. On newer macs  (Built after 2011)   <keycap>C</keycap>  is usually sufficient.

  					</para>

  				</note>

  			</step>
@@ -87,13 +87,13 @@ 

  		<note>

  			<para>

  				Editing boot options in <application>GRUB2</application> (on UEFI systems) will display the entire configuration for the selected entry. Actual boot options are configured on the line which starts with the <literal>linux</literal> (or <literal>linux16</literal> or <literal>linuxefi</literal>) keyword. Do not modify any other lines in the configuration.

- 			</para>

+ 			</para><F12><F12><F12>

oops :)

  			<para>

So a 'nothing to see here, move along' ?

Remove '<F12><F12><F12>' . I'm assuming it's an accident.

  				On systems with BIOS firmware, only the actual boot options are displayed when you press <keycap>Tab</keycap>.

  			</para>

  		</note>

  		<para>

- 			When editing the default set of options, you can change the existing ones as well as append additional ones. Once you finish, press <keycap>Enter</keycap> on BIOS or <keycombo><keycap>Ctrl</keycap><keycap>X</keycap></keycombo> on UEFI to boot the installer using your customized options.

+ 			When editing the default set of options, you can change the existing ones as well as append additional ones. Once you finish, press <keycap>Enter</keycap> on BIOS or <keycombo><keycap>F10</keycap> on UEFI to boot the installer using your customized options.

GRUB gives you the option of both a function key and ctl+x to boot; in my experience, ctl+x works universally but the function key does not on some systems. ctl+x also aligns with the downstream RHEL Installation Guide.

  		</para>

Never seen or used the Ctl+X myself but sure, not sure the RHEL part should really dictate our docs that much tho tbh.

  		<figure>

  			<title>Editing boot options on a system with BIOS firmware</title>

file modified
+2 -2
@@ -75,7 +75,7 @@ 

  			</imageobject>

  			<textobject>

  				<para>

- 					The Rescan Disks dialog, showing a completed scan. Pressing OK now will take you back to the Installation Destination screen.

+ 					The Rescan Disks dialog, showing a completed scan. Pressing OK now will take you back to the Installation Destination screen. This process CAN take awkile depending on disk(s) layouts and  size(s).

A good addition, but a few thoughts on presentation:

  • We shouldn't capitalize for emphasis. If the concept is important enough to call special attention to it,
    an admonition would be more appropriate, ie <note>, <important>, or <warning>. If the idea does not warrant
    an admonition, we probably don't need to emphasize it more than an <emphasis> tag around a phrase.
  • 'disk layout' and 'disk size' doesn't need to be pluralized, you could more succinctly say 'disk layout and size'.
  • s/awkile/awhile/

  				</para>

  			</textobject>

  		</mediaobject>
@@ -84,7 +84,7 @@ 

  		After you finish configuring your system storage, press <guilabel>Done</guilabel> in the top left corner to save the configuration and return to the <guilabel>Installation Summary</guilabel> screen. At this point, the installer will check if your storage configuration is valid. If an error was detected, a message will be displayed at the bottom of the screen. Click the message to open a dialog window explaining what kind of error has been detected (for example, you put <filename class="directory">/boot</filename> on a Btrfs subvolume, or you did not create a BIOS Boot partition when your system requires one).

  	</para>

  	<para>

- 		If such a message is displayed, go back and fix any issues found by the installer; otherwise you will not be able to proceed with the installation. You can also press <guilabel>Done</guilabel> again to return to the <guilabel>Installation Summary</guilabel> anyway, but a storage configuration error will prevent you from starting the actual installation process.

+ 		If such a message is displayed, go back and fix any issues found by the installer; otherwise you will not be able to proceed with the installation. You can also press <guilabel>Done</guilabel> again to return to the <guilabel>Installation Summary</guilabel> anyway, but a storage configuration error will prevent you from starting the actual installation process. The only exception is  for the <filename>swap</filename> partition.

I wouldn't qualify an "Are you sure you want swap?" type message with blocking filesystem layout error messages, to the point that I actually had to reread this several times to get what you were communicating. This should be rephrased to be more clear, or maybe even just left as is.

  	</para>

  	<para>

  		If no error message is displayed and if you made any changes since the last time you have visited this screen, a summary dialog will appear, displaying a detailed list of the changes you made. Review the list and click <guilabel>Accept Changes</guilabel> to proceed with <xref linkend="sect-installation-gui-installation-summary" />, or click <guilabel>Cancel &amp; Return to Custom Partitioning</guilabel> if you want to make any more changes.

file modified
+1 -1
@@ -79,7 +79,7 @@ 

  			</para>

  			<note>

  				<para>

- 					The configuration dialog does not allow you to specify the size of the volume group's <firstterm>physical extents</firstterm>. The size will always be set to the default value of 4 MiB. If you want to create a volume group with different physical extents, create it manually by switching to an interactive shell and using the <command>vgcreate</command> command, or use a Kickstart file with the <command>volgroup --pesize=<replaceable>size</replaceable></command> command. 

+ 					The configuration dialog does not allow you to specify the size of the volume group's <firstterm>physical extents</firstterm>. The size will always be set to the default value of 4 MiB. If you want to create a volume group with different physical extents, create it manually by switching to an interactive shell(<keycap>Ctrl</keycap>+<keycap> Alt</keycap>+<keycap>F2</keycap> ) and using the <command>vgcreate</command> command, or use a Kickstart file with the <command>volgroup --pesize=<replaceable>size</replaceable></command> command. 

Good addition! DocBook also has a <keycombo> tag you can use to wrap a set of <keycap> tags, but it isn't imperative.

  				</para>

  			</note>

  		</step>

@@ -54,12 +54,12 @@ 

  		</step>

  		<step>

  			<para>

- 				In the <guilabel>Device(s)</guilabel> section on the right side of the screen, you can see that the partition has been assigned to one or more hard drives. Click the <guilabel>Modify</guilabel> button to configure on which drive this partition will be created.

+ 				In the <guilabel>Device(s)</guilabel> section on the right side of the screen, you can see that the partition has been assigned to your hard drive(s). Click the <guilabel>Modify</guilabel> button to configure on which drive this partition will be created.

I actually prefer the brevity you've added to this sentence, but I don't think we should make this change for a different reason. The change is minor and doesn't affect what the sentence communicates, but the act of changing it will require all translations of the sentence be performed again. It adds a deceptively large amount of work for such a small change.

  			</para>

It seems to read better with the brevity, hence I question if the l10n hit might be worth it on this one.

I agree that it reads better, but no, it isn't worth it. You're asking at least one and probably two people from each of dozens of language teams to review and and translate the string, there isn't enough value in the added brevity to justify that.

  		</step>

  		<step>

  			<para>

- 				In the <guilabel>Configure Mount Point</guilabel> dialog, you can specify which physical devices (disks) this volume <emphasis>may</emphasis> reside on. You can select one or more disks which will be used to hold this volume by holding down <keycap>Ctrl</keycap> and clicking each disk in the list. If you select multiple disks here, <application>Anaconda</application> will determine where exactly the partition should be created based on how you configured the rest of the installation. If you want to make sure that this partition is placed on a specific hard drive, select only that drive and unselect all others.

+ 				In the <guilabel>Configure Mount Point</guilabel> dialog, you can specify which physical devices (disks) this volume <emphasis>may</emphasis> reside on. You can select any one of your disks which will be used to hold this volume.. If you select multiple disks here, <application>Anaconda</application> will determine where exactly the partition should be created based on how you configured the rest of the installation. If you want to make sure that this partition is placed on a specific hard drive, select only that drive and unselect all others.

brevity vs l10n team effort concerns apply here too.

  			</para>

  			<para>

  				After you finish configuring the partition's location, click <guilabel>Save</guilabel> to return to the main <guilabel>Manual Partitioning</guilabel> screen.

@@ -28,7 +28,7 @@ 

  		</listitem>

  		<listitem> 

  			<para>

- 				<guilabel>LVM Thin Provisioning</guilabel> - Using thin provisioning, you can manage a storage pool of free space, known as a <firstterm>thin pool</firstterm>, which can be allocated to an arbitrary number of devices when needed by applications. The thin pool can be expanded dynamically when needed for cost-effective allocation of storage space.

+ 				<guilabel>LVM Thin Provisioning</guilabel> - Using thin provisioning, you can manage a storage pool of free space, known as a <firstterm>thin pool</firstterm>, which can be allocated to an arbitrary number of devices when needed by applications. The thin pool can be expanded dynamically when needed for cost-effective allocation of storage space. (Still experimental-- not recommended for mission critical production systems)

I don't see thinp as 'experimental' at this point. Is there a reference we can cite here?

  			</para>

  		</listitem>

  		<listitem>
@@ -38,7 +38,7 @@ 

  		</listitem>

  		<listitem>

  			<para>

- 				<guilabel>BTRFS</guilabel> - Btrfs is a file system with several device-like features. It is capable of addressing and managing more files, larger files, and larger volumes than the ext2, ext3, and ext4 file systems. See <xref linkend="sect-installation-gui-manual-partitioning-btrfs" /> for more information about creating Btrfs volumes. 

+ 				<guilabel>BTRFS</guilabel> - Btrfs is a file system with several device-like features. It is capable of addressing and managing more files, larger files, and larger volumes than the ext2, ext3, and ext4 file systems. See <xref linkend="sect-installation-gui-manual-partitioning-btrfs" /> for more information about creating Btrfs volumes. (Still experimental-- not recommended for mission critical production systems)

This is a good point to add, but I think we can be more positive in delivery. It would be best to have an article, list discussion, or document to point to , ie "For information on the features and limitations of btrfs, refer to..." and implicitly recommend that the reader make a decision for themselves.

  			</para>

  		</listitem>

  	</itemizedlist>
@@ -60,17 +60,18 @@ 

  			</para>

  		</listitem>

  		<listitem>

+ 

  			<para>

- 				<guilabel>swap</guilabel> - Swap partitions are used to support virtual memory. In other words, data is written to a swap partition when there is not enough RAM to store the data your system is processing. A swap partition should always be created; see <xref linkend="sect-installation-gui-manual-partitioning-recommended" /> for details such as the recommended size.

+ 				<guilabel>swap</guilabel> - Swap partitions are used to support virtual memory. In other words, data is written to a swap partition when there is not enough RAM to store the data your system is processing. A swap partition should always be created on systems with  < 2Gb RAM; see <xref linkend="sect-installation-gui-manual-partitioning-recommended" /> for details such as the recommended size.

Because we're working with XML, the '<' character should be represented with it's entity, &lt'. There's a list of such things and more info at http://www.docbook.org/tdg/en/html/ch01.html#s-entities .

  			</para>

  		</listitem>

  		<listitem>

  			<para>

- 				<guilabel>xfs</guilabel> - XFS is a highly scalable, high-performance file system that supports file systems up to 16 exabytes (approximately 16 million terabytes), files up to 8 exabytes (approximately 8 million terabytes), and directory structures containing tens of millions of entries. XFS also supports metadata journaling, which facilitates quicker crash recovery. The maximum supported size of a single XFS file system is 500 TB. Starting with &PRODUCT;&nbsp;22, XFS is the default and recommended file system on &PRODUCT; Server.

+ 				<guilabel>xfs</guilabel> - XFS is a highly scalable, high-performance file system that supports file systems up to 16 exabytes (approximately 16 million terabytes), files up to 8 exabytes (approximately 8 million terabytes), and directory structures containing tens of millions of entries. XFS also supports metadata journaling, which facilitates quicker crash recovery. The maximum supported size of a single XFS file system is 500 TB. Starting with &PRODUCT;&nbsp;24, XFS is the default and recommended file system on &PRODUCT; Server.

  			</para>

  			<important>

  				<para>

- 					Note that the size of an XFS file system can not currently be reduced without destroying and recreating the file system. If you expect that you will need to adjust the sizes of your file systems often, using XFS is not recommended, as it makes administration substantially more time-consuming.

+ 					Note that the size of an XFS file system can not currently be reduced without destroying and recreating the file system. If you expect that you will need to adjust the sizes of your file systems often, using XFS is not recommended, as it makes administration substantially more time-consuming. However XFS filesystems can be  'grown' aka  increased  while mounted and active.

hmm... this could be made more succinct if you clarified in the first sentence that XFS cannot be shrunk, only grown.

  				</para>

  			</important>

  		</listitem>

@@ -21,7 +21,7 @@ 

  		</listitem>

  		<listitem>

  			<para>

- 				Some special restrictions apply to certain directories with regards on which partitioning layouts can they be placed. Notably, the <filename class="directory">/boot</filename> directory must always be on a physical partition (not on an LVM volume or a Btrfs subvolume), and <filename class="directory">/usr</filename> can not be on a Btrfs subvolume.

+ 				Some special restrictions apply to certain directories with regards to which partitioning layouts can they be placed. Notably, the <filename class="directory">/boot</filename> directory must always be on a physical partition (not on an LVM volume or a Btrfs subvolume), and <filename class="directory">/usr</filename> can not be on a Btrfs subvolume.

  			</para>

  		</listitem>

  		<listitem>
@@ -31,7 +31,7 @@ 

  		</listitem>

  		<listitem>

  			<para>

- 				Each kernel installed on your system requires approximately 20 MB on the <filename class="directory">/boot</filename> partition. The default partition size of 500 MB for <filename class="directory">/boot</filename> should suffice for most common uses; increase the size of this partition if you plan to keep many kernels installed at the same time.

+ 				Each kernel installed on your system requires approximately 20 MB on the <filename class="directory">/boot</filename> partition. The default partition size of 500 MB for <filename class="directory">/boot</filename> should suffice for most common uses; increase the size of this partition if you plan to keep many kernels installed at the same time, or you use debug kernel as the debug symbols can get massive.

how about ..."or if you use a debug kernel, as debug symbols" ? It might be nice to give a rough estimate too, do you know how much space is consumed with the default (installonly_limit) number of debug kernels installed?

  			</para>

  		</listitem>

  		<listitem>
@@ -41,7 +41,7 @@ 

  		</listitem>

  		<listitem>

  			<para>

- 				The contents of the <filename class="directory">/var</filename> directory usually change very often. This may cause problems with older solid state drives (SSDs), as they can handle a lower number of read/write cycles before becoming unusable. If your system root is on an SSD, consider creating a separate mount point for <filename class="directory">/var</filename> on a classic (platter) HDD.

+ 				The contents of the <filename class="directory">/var</filename> directory usually change very often. This may cause problems with older solid state drives (SSDs), as they can only handle a lower number of read/write cycles before becoming unusable. If your system root is on an SSD, consider creating a separate mount point for <filename class="directory">/var</filename> on a classic (platter) HDD.

Now that you bring attention to it, I think the technology has progressed to the point that we can defer with this recommendation. Since changing this would require retranslation, I think it would be better to research the validity of the recommendation before changing the copy.

  			</para>

  		</listitem>

  		<listitem>

@@ -22,6 +22,10 @@ 

  					<para>

  						Also note that the <filename class="directory">/boot</filename> directory can not be placed on a LVM logical volume or a Btrfs subvolume. Use a standard partition.

  					</para>

+ 					<para>

+                                                 Also note that the <filename class="directory">/boot/efi</filename> directory can not be placed on a LVM logical volume or a Btrfs subvolume. Use a standard partition, but is needed for  UEFI / EFI systems.  50MB to 100MB is suffiecient for most common uses.

Good catch! We could save some reading time by mentioning /boot/efi with /boot, instead of adding a new paragraph.

+                                         </para>

+ 

  				</important>

  			</listitem>

  		</varlistentry>
@@ -32,7 +36,7 @@ 

  					This is where the root directory is located. The root directory is the top level of the directory structure. By default, all files are written to this partition unless a different partition is mounted in the path being written to (for example, <filename class="directory">/boot</filename> or <filename class="directory">/home</filename>). If you follow the recommended scheme described in this section, this will be the partition where most software packages will be installed.

  				</para>

  				<para>

- 					For a minimal installation, a 5 GB root partition will be sufficient. However, for most common installations which include extra packages and a graphical user interface, the root partition should be at least 10 GB; with 20 GB being sufficient for most common use cases.

+ 					For a minimal installation, a 5 GB root partition will be sufficient. However, for most common installations which include extra packages and a graphical user interface, the root partition should be at least 10 GB; with 20 GB being sufficient for most common use cases. If using the auto partioner, it  will select 50Gb for <filename>/</filename>  unless available disk space disallows it.

I'm wary of describing the default value here; If you use the installer you'll discover the info on your own, and if we cite that here we'll have to verify the citation for every release.

  				</para>

  				<note>

  					<para>
@@ -45,7 +49,7 @@ 

  			<term><filename class="directory">/home</filename> - at least 10 GB</term>

  			<listitem>

  				<para>

- 					To store user data separately from system data, create a dedicated mount point for the <filename>/home</filename> directory. This partition should be sized based on the amount of data that will be stored locally, number of users, and so on. This will allow you to upgrade or reinstall &PRODUCT; without erasing user data files. During the installation, a separate <filename class="directory">/home</filename> partition will be created if there are 50 GB or more free space for your &PRODUCT; installation.

+ 					To store user data separately from system data, create a dedicated mount point for the <filename>/home</filename> directory. This partition should be sized based on the amount of data that will be stored locally, number of users, and so on. This will allow you to upgrade or reinstall &PRODUCT; without erasing user data files. During the installation, a separate <filename class="directory">/home</filename> partition will be created if there are 50 GB or more free space for your &PRODUCT; installation, and  will by default will use the balance of  space available after <filename>/</filename>, <filename> /boot</filename>, and any other selected partitions.

  				</para>

  				<para>

  					When using &PRODUCT; as a workstation for normal use with a graphical environment, this mount point should have the most disk space assigned to it, as it will likely hold the most data (user settings, images, videos, etc).
@@ -59,7 +63,7 @@ 

  					Swap partitions support virtual memory; data is written to them when there is not enough RAM to store the data your system is processing. This partition's size is a function of system memory workload, not total system memory, and therefore is not equal to the total system memory size. Therefore, it is important to analyze what applications a system will be running and the load those applications will serve in order to determine the system memory workload. Application providers and developers should be able to provide some guidance.

  				</para>

  				<para>

- 					When the system runs out of swap space, the kernel terminates processes as the system RAM memory is exhausted. Configuring too much swap space results in storage devices being allocated but idle and is a poor use of resources. Too much swap space can also hide memory leaks. The maximum size for a swap partition and other additional information can be found in the <systemitem>mkswap(8)</systemitem> man page. 

+ 					When the system runs out of swap space, the kernel terminates processes as the system RAM memory is exhausted. Configuring too much swap space results in storage devices being allocated but idle and is a poor use of resources. Too much swap space can also hide memory leaks. The maximum size for a swap partition and other additional information can be found in the <systemitem>mkswap(8)</systemitem> man page. While less effective <filename>zRAM</filename> may be  used for a more 'dynamic' use of  available disk space (in luie of, or addition to a swap space.

s/luie/lieu/ , and there's an open parenthesis without it's close.

  				</para>

  				<para>

  					The table below provides the recommended size of a swap partition depending on the amount of RAM in your system and whether you want sufficient memory for your system to hibernate. If you let the installation program partition your system automatically, the swap partition size will be established using these guidelines. Automatic partitioning setup assumes hibernation is not in use, and the maximum size of the swap partition is limited to 10% of the total size of the hard drive. If you want to set up enough swap space to allow for hibernation, or if you want to set the swap partition size to more than 10% of the system's storage space, you must edit the partitioning layout manually. 

file modified
+6 -6
@@ -66,7 +66,7 @@ 

  			<itemizedlist>

  				<listitem>

  					<para>

- 						A small percentage of the driver's available space is used to store file system-related data and can be considered as overhead.

+ 						A small percentage of the drive's available space is used to store file system-related data and can be considered as overhead.

  					</para>

  				</listitem>

  				<listitem>
@@ -81,7 +81,7 @@ 

  				</listitem>

  			</itemizedlist>

  			<para>

- 				Note that there is no single, universal file system. As <xref linkend="figu-partitions-different-file-system" />, shows, a disk drive may have one of many different file systems written on it. Different file systems tend to be incompatible; that is, an operating system that supports one file system (or a handful of related file system types) may not support another. However, &PRODUCT; supports a wide variety of file systems (including many commonly used by other operating systems such as Microsoft Windows), making data interchange between different file systems easy.

+ 				Note that there is no single, universal file system. As <xref linkend="figu-partitions-different-file-system" />, shows, a disk drive may have one of many different file systems written on it. Different file systems tend to be incompatible; that is, an operating system that supports one file system (or a handful of related file system types) may not support another. However, &PRODUCT; supports a wide variety of file systems (including many commonly used by other operating systems such as Microsoft Windows<filename>ntfs</filename> and Mac OSX <filename> hfs/hfs+</filename> ), making data interchange between different file systems easy.

  			</para>

  			<figure id="figu-partitions-different-file-system">

  				<title>Disk Drive with a Different File System</title>
@@ -131,7 +131,7 @@ 

  			<itemizedlist>

  				<listitem>

  					<para>

- 						Logical separation of the operating system data from the user data

+ 						Logical separation of the operating system data from the user data (Makes backup / restore easier)

  					</para>

  				</listitem>

  				<listitem>
@@ -141,7 +141,7 @@ 

  				</listitem>

  				<listitem>

  					<para>

- 						Ability to run multiple operating systems on one machine

+ 						Ability to run multiple operating systems on one machine (Dual / Multi Booting)

  					</para>

  				</listitem>

  			</itemizedlist>
@@ -586,7 +586,7 @@ 

  			</itemizedlist>

  			<important>

  				<para>

- 					There must be a BIOS boot partition for the boot loader to be installed successfully onto a disk that contains a GPT (GUID Partition Table). This includes disks initialized by <application>Anaconda</application>. If the disk already contains a BIOS boot partition, it can be reused.

+ 					There must be a BIOS boot partition for the boot loader to be installed successfully onto a disk that contains a GPT (GUID Partition Table). This includes disks initialized by <application>Anaconda</application>. If the disk already contains a BIOS boot partition, it can be reused. For EFI systems  BIOS Boot is  replaced by /boot/efi.

  				</para>

  			</important>

  		</section>
@@ -658,7 +658,7 @@ 

  			<para>

  				In this case, maybe you have one or more partitions that you do not use any longer. <xref linkend="figu-partitions-unused-partition" />, illustrates such a situation.

  			</para>

- 			<figure id="figu-partitions-unused-partition">

+ 			<figure id="figu-partitions-unused-partition">q

Typo here, please revert.

  				<title>Disk Drive with an Unused Partition</title>

  				<mediaobject>

  					<imageobject>

file modified
+2 -2
@@ -82,7 +82,7 @@ 

  					The netinstall image boots directly into the installation environment, and uses the online Fedora package repositories as the installation source.   With a netinstall image, you can select a wide variety of packages to create a customized installation of Fedora.

  				</para>

  				<para>

- 					The Fedora Server netinstall image is a universal one, and can be used to install any Fedora flavor or your own set of favorite packages.

+ 					The Fedora Server netinstall image is a universal one, and can be used to install any Fedora flavor or your own set of favorite packages. By Default, requires a  Ethernet connection / NFS --Unlike the live optionn this option DOES NOT  have  wifi installed by default.

Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a <note> admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic.

Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a <note> admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic.

  				</para>

  			</listitem>

  		</varlistentry>
@@ -115,7 +115,7 @@ 

  			<term>Boot Images</term>

  			<listitem>

  				<para>

- 					The tiny images at <ulink url="https://boot.fedoraproject.org/" /> are written to CDs, USB drives, or even floppy disks. The BFO image loads installation media from Fedora's servers and directly loads an installation environment, like the netinstall ISO.

+ 					The tiny images at <ulink url="https://boot.fedoraproject.org/" /> are written to CDs, USB drives. The BFO image loads installation media from Fedora's servers and directly loads an installation environment, like the netinstall ISO.

  				</para>

  				<para>

  					BFO images work like PXE deployments, without having to set up a server.

file modified
+4 -4
@@ -1,9 +1,9 @@ 

  <!ENTITY PRODUCT "Fedora">

- <!ENTITY NEXTVER "24">

- <!ENTITY PRODVER "23">

- <!ENTITY PREVVER "22">

+ <!ENTITY NEXTVER "25">

+ <!ENTITY PRODVER "24">

+ <!ENTITY PREVVER "23">

  <!ENTITY BOOKID "install-guide">

- <!ENTITY YEAR "2015">

+ <!ENTITY YEAR "2016">

  <!ENTITY HOLDER "Red Hat, Inc. and others">

  <!ENTITY BZURL "<ulink url='https://bugzilla.redhat.com/enter_bug.cgi?product=&PRODUCT;&amp;component=&BOOKID;'>https://bugzilla.redhat.com</ulink>" >

  <!ENTITY IGURL '<ulink url="http://docs.fedoraproject.org/" />'>

@@ -88,7 +88,7 @@ 

  					<tbody>

  						<row>

  							<entry>

- 								<keycombo><keycap>Ctrl</keycap><keycap>b</keycap></keycombo> <keycap>1</keycap>

+ 								<keycombo><keycap>Ctrl</keycap><keycap>Alt</keycap></keycombo> <keycap>1</keycap>

This section describes interacting with a tmux window, your edits to the keycombos are incorrect and should be reverted.

  							</entry>

  							<entry>

  								Main installation program window. Contains text-based prompts (during text mode installation or if you use VNC direct mode), and also some debugging information.
@@ -96,7 +96,7 @@ 

  						</row>

  						<row>

  							<entry>

- 								<keycombo><keycap>Ctrl</keycap><keycap>b</keycap></keycombo> <keycap>2</keycap>

+ 								<keycombo><keycap>Ctrl</keycap><keycap>Alt</keycap></keycombo> <keycap>2</keycap>

  							</entry>

  							<entry>

  								Interactive shell prompt with <systemitem class="username">root</systemitem> privileges.
@@ -104,7 +104,7 @@ 

  						</row>

  						<row>

  							<entry>

- 								<keycombo><keycap>Ctrl</keycap><keycap>b</keycap></keycombo> <keycap>3</keycap>

+ 								<keycombo><keycap>Ctrl</keycap><keycap>Alt</keycap></keycombo> <keycap>3</keycap>

  							</entry>

  							<entry>

  								Installation log; displays messages stored in <filename>/tmp/anaconda.log</filename>.
@@ -112,7 +112,7 @@ 

  						</row>

  						<row>

  							<entry>

- 								<keycombo><keycap>Ctrl</keycap><keycap>b</keycap></keycombo> <keycap>4</keycap>

+ 								<keycombo><keycap>Ctrl</keycap><keycap>Alt</keycap></keycombo> <keycap>4</keycap>

  							</entry>

  							<entry>

  								Storage log; displays messages related storage devices from kernel and system services, stored in <filename>/tmp/storage.log</filename>.
@@ -120,7 +120,7 @@ 

  						</row>

  						<row>

  							<entry>

- 								<keycombo><keycap>Ctrl</keycap><keycap>b</keycap></keycombo> <keycap>5</keycap>

+ 								<keycombo><keycap>Ctrl</keycap><keycap>Alt</keycap></keycombo> <keycap>5</keycap>

  							</entry>

  							<entry>

  								Program log; displays messages from other system utilities, stored in <filename>/tmp/program.log</filename>.
@@ -176,7 +176,7 @@ 

  		<itemizedlist>

  			<listitem>

  				<para>

- 					The installer will always use the English language and the US English keyboard layout. You can configure your language and keyboard settings, but these settings will only apply to the installed system, not to the installation.

+ 					The installer will always use the English language and the US English keyboard layout. You can configure your language and keyboard settings, but these settings will only apply to the installed system, not to the installation system (aka Live Media)

This entire statement seems incorrect - doesn't the installer ask you about language and layout before anything else, continue the installation using those settings, and install a system with the same settings?

  				</para>

Just noticed that will fix it up. It's totally outdated.

  			</listitem>

  			<listitem>

file modified
+4 -4
@@ -21,7 +21,7 @@ 

  			</imageobject>

  			<textobject>

  				<para>

- 					The Kdump configuration screen, showing 128 MB reserved

+ 					The Kdump configuration screen, showing 128 MB reserved. (Default reservation)

This file isn't actually published to the site, it's used by anaconda for inline help. We keep it in this repo because other content overlaps, and anacondas help files are generated from the installation guide. In that context, it doesn't make sense to make this change, please revert.

  				</para>

  			</textobject>

  		</mediaobject>
@@ -30,13 +30,13 @@ 

  		<application>Kdump</application> is a kernel crash dumping mechanism which, in the event of a system crash, captures the contents of the system memory at the moment of failure. This captured memory can then be analyzed to find the cause of the crash. If <application>Kdump</application> is enabled, it must have a small portion of the system's memory (RAM) reserved to itself. This reserved memory will not be accessible to the main kernel.

  	</para>

  	<para>

- 		To enable <application>Kdump</application> on the installed system, check <guilabel>Enabled</guilabel>. Then, select either <guilabel>Automatic</guilabel> or <guilabel>Manual</guilabel> memory reservation settings, and if you selected <guilabel>Manual</guilabel>, enter the amount of memory to be reserved in megabytes into the <guilabel>Memory to be reserved</guilabel> field.

+ 		To enable <application>Kdump</application> on the installed system, check <guilabel>Enabled</guilabel>. Then enter the amount of memory to be reserved in megabytes into the <guilabel>Memory to be reserved</guilabel> field.

Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist?

Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist?

  	</para>

auto does not auto select a value anymore, except on server.

  	<para>

- 		The amount of memory which you should reserve is determined based on your system's architecture (AMD64 and Intel&nbsp;64 will have different requirements than IBM Power, for example) as well as the total amount of system memory. In most cases, automatic reservation will be satisfactory. If you insist on manual settings, see the <ulink url="https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Kernel_Crash_Dump_Guide/appe-supported-kdump-configurations-and-targets.html#sect-kdump-memory-requirements">Red&nbsp;Hat Enterprise&nbsp;Linux&nbsp;7 Kernel Crash Dump Guide</ulink> for guidelines. This document also contains more in-depth information about how <application>Kdump</application> works, how to configure additional settings, and how to analyze a saved crash dump.

+ 		The amount of memory which you should reserve is determined based on your system's architecture (AMD64 and Intel&nbsp;64 will have different requirements than IBM Power, for example) as well as the total amount of system memory. In most cases, the default reservation will be satisfactory. If you insist on manual settings, see the <ulink url="https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/7/html/Kernel_Crash_Dump_Guide/appe-supported-kdump-configurations-and-targets.html#sect-kdump-memory-requirements">Red&nbsp;Hat Enterprise&nbsp;Linux&nbsp;7 Kernel Crash Dump Guide</ulink> for guidelines. This document also contains more in-depth information about how <application>Kdump</application> works, how to configure additional settings, and how to analyze a saved crash dump.

  	</para>

  	<para>

- 		The <guilabel>Usable System Memory</guilabel> readout below the reservation input field shows how much memory will be accessible to your main system once your selected amount of RAM is reserved.

+ 		The <guilabel>Usable System Memory</guilabel> readout below the reservation input field shows how much memory will be accessible to your main system once your selected amount of RAM is reserved. On low RAM systems this is something to watch out for.  Too much kdump reservation could leave the system crippling slow or   unusable.

This is mostly a general observation that memory constraints have a performance impact, I don't think we need to make that observation here.

  	</para>

  	<note>

  		<para>

file modified
+3 -2
@@ -51,8 +51,9 @@ 

  		</listitem>

  		<listitem>

  			<para>

- 				The up and down buttons can be used to move the highlighted layout up or down in the list.

- 			</para>

+ 				The up and down buttons can be used to move the highlighted layout up or down in the list. Topmost selection will be  defaul

+ t on the installed system .

We don't need to point out that the UI element that is highlighted when the dialog opens will be the option chosen unless specified otherwise.

+ 	 		</para>

  		</listitem>

  		<listitem>

  			<para>

@@ -6,7 +6,7 @@ 

  <chapter id="chap-kickstart-installations">

  	<title>Automating the Installation with Kickstart</title>

  	<para>

- 		Kickstart installations offer a means to automate the installation process, either partially or fully. Kickstart files contain answers to all questions normally asked by the installation program, such as what time zone do you want the system to use, how should the drives be partitioned or which packages should be installed. Providing a prepared Kickstart file when the installation begins therefore allows the you to perform the installation automatically, without need for any intervention from the user. This is especially useful when deploying &PRODUCT; on a large number of systems at once.

+ 		Kickstart installations offer a means to automate the installation process, either partially or fully. Kickstart files contain answers to all questions normally asked by the installation program, such as what time zone do you want the system to use, how should the drives be partitioned or which packages should be installed. Providing a prepared Kickstart file when the installation begins therefore allows the user to perform the installation automatically, without need for any intervention from the user. This is especially useful when deploying &PRODUCT; on a large number of systems at once.

This change doesn't merit retranslation, please revert.

  	</para>            

  	<para>

  		All Kickstart scripts and the log files of their execution are stored in the <filename>/tmp</filename> directory to assist with debugging installation issues.
@@ -72,7 +72,7 @@ 

  							<para>

  								The command section which contains actual Kickstart commands and options as listed in <xref linkend="appe-kickstart-syntax-reference" />. Note that some commands, such as <command>install</command>, are mandatory, but most commands are optional.

  							</para>

- 						</listitem>

+ 						</listitem>		

This is just whitespace added to the end of the line, I think. Not a big problem or a blocker to a merge, but as a practice you should be careful about leaking superfluous changes into your commits.

  						<listitem>

  							<para>

  								The <command>%packages</command> section which contains a list of packages and package groups to be installed. See <xref linkend="sect-kickstart-packages" /> for details.
@@ -107,7 +107,7 @@ 

  			<para>

  				After installing the package, you can validate a Kickstart file using the following command:

  			</para>

- 			<screen><prompt>$</prompt> <command>ksvalidator <replaceable>/path/to/kickstart.ks</replaceable></command></screen>

+ 			<screen><prompt>$</prompt> <command>python3-krsvalidator <replaceable>/path/to/kickstart.ks</replaceable></command></screen>

/usr/bin/pykickstartexists, and is written in python3. Please revert this change.

  			<para>

  				Replace <replaceable>/path/to/kickstart.ks</replaceable> with the path to the Kickstart file you want to verify.

  			</para>

@@ -18,14 +18,15 @@ 

  		</para>

  		<programlisting>

  <command>part / --fstype=xfs --onpart=/dev/disk/by-path/pci-0000:00:05.0-scsi-0:0:0:0-part1</command>

- <command>part / --fstype=xfs --onpart=/dev/disk/by-id/ata-ST3160815AS_6RA0C882-part1</command>

+ <command>part / --fstype=xfs --onpart=/dev/disk/by-id/ata-ST3160815AS_6RA0C882-part1</command>i

+ <command>part / --fstype=xfs --onpart=/dev/disk/by-uuid/ba555f30-1708-4015-9477-64d65a59f3e9-part1</command>

This set of changes serves no purpose, please revert.

  		</programlisting>

  		<para>

  			This provides a consistent way to refer to disks that is more meaningful than just <literal>sda</literal>. This is especially useful in large storage environments.

  		</para>

  	</important>

  	<para>

- 		While the general principles of Kickstart installations tend to stay the same, the commands and options can change between major releases. You can use the <command>ksverdiff</command> command to display the differences between two versions of the Kickstart syntax. This is useful when updating an existing Kickstart file to be used with a new release. To display a list of changes in syntax between Fedora&nbsp;&PREVVER; and &PRODVER;, use the following command:

+ 		While the general principles of Kickstart installations tend to stay the same, the commands and options can change between major releases. You can use the <command>ksverdiff</command> command to display the differences between two versions of the Kickstart syntax.(Requires python3-ksvalidator)  This is useful when updating an existing Kickstart file to be used with a new release. To display a list of changes in syntax between Fedora&nbsp;&PREVVER; and &PRODVER;, use the following command:

The pykickstart package provides /usr/bin/ksvalidator, python3-kickstart is strictly python modules. Please revert.

  	</para>

  	<screen><prompt>$</prompt> <command>ksverdiff -f F&PREVVER; -t F&PRODVER;</command></screen>

  	<para>
@@ -39,73 +40,8 @@ 

  			In the following sections, if an option is followed by an equals mark (<literal>=</literal>), a value must be specified after it. In the example commands, options in square brackets (<literal>[ ]</literal>) are optional arguments for the command.

  		</para>

  	</note>

- 	<section id="sect-kickstart-commands-installation">

- 		<title>Installation Methods and Sources</title>

- 		<para>

- 			The following commands control the way Fedora will be installed.

- 		</para>

- 

- 		<section id="sect-kickstart-commands-device">

- 			<title>device (optional) - Install Extra Device Drivers</title>

- 			<para>

- 				On most PCI systems, the installation program will automatically detect Ethernet and SCSI cards. However, on older systems and some PCI systems, Kickstart requires a hint to find the proper devices. The <command>device</command> command, which tells the installation program to install extra modules, uses the following format:

- 			</para>

- 			<programlisting><command>device <replaceable>moduleName</replaceable> [--opts=]</command></programlisting>

- 			<para>

- 				Replace <replaceable>moduleName</replaceable> with the name of the kernel module which should be installed.

- 			</para>

- 			<variablelist>

- 				<varlistentry>

- 					<term><option>--opts=</option></term>

- 					<listitem>

- 						<para>

- 							Options to pass to the installed kernel module. For example:

- 						</para>

- 						<programlisting><command>device i2c_piix4 --opts="aic152x=0x340 io=11"</command></programlisting>

- 					</listitem>

- 				</varlistentry>

- 			</variablelist>

- 		</section>

- 

- 		<section id="sect-kickstart-commands-driverdisk">

- 			<title>driverdisk (optional) - Use a Driver Disk</title>

- 			<para>

- 				Driver disks can be used during Kickstart installations to provide additional drivers not included by default. You must copy the driver disks's contents to the root directory of a partition on the system's hard drive. Then, you must use the <command>driverdisk</command> command to specify that the installation program should look for a driver disk and its location.

- 			</para>

- 			<programlisting><command>driverdisk <replaceable>partition</replaceable> | --source= | --biospart=</command></programlisting>

- 			<variablelist>

- 				<varlistentry>

- 					<term><replaceable>partition</replaceable></term>

- 					<listitem>

- 						<para>

- 							Search for the driver disk image on a local partition. Replace <replaceable>partition</replaceable> with the name of the partition containing the driver disk. Note that the partition must be specified as a full path. For example:

- 						</para>

- 						<programlisting><command>driverdisk /dev/sdb1</command></programlisting>

- 					</listitem>

- 				</varlistentry>

- 				<varlistentry>

- 					<term><option>--source=</option></term>

- 					<listitem>

- 						<para>

- 							Search for the driver disk in a network location instead of a local partition. For example:

- 						</para>

- 						<programlisting><command>driverdisk --source=ftp://<replaceable>path/to/dd.img</replaceable></command></programlisting>

- 						<programlisting><command>driverdisk --source=http://<replaceable>path/to/dd.img</replaceable></command></programlisting>

- 						<programlisting><command>driverdisk --source=nfs:<replaceable>hostname</replaceable>:/<replaceable>path/to/dd.img</replaceable></command></programlisting>

- 					</listitem>

- 				</varlistentry>

- 				<varlistentry>

- 					<term><option>--biospart=</option></term>

- 					<listitem>

- 						<para>

- 							BIOS partition containing the driver disk (for example, <literal>82p2</literal>).

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 			</variablelist>

- 		</section>

- 

- 		<section id="sect-kickstart-commands-install">

+ 	

+ 	<section id="sect-kickstart-commands-install">

This is a duplicate pair of lines, please revert.

  			<title>install (required) - Configure Installation Method</title>

  			<para>

  				The default installation mode. You must specify the type of installation from <literal>cdrom</literal>, <literal>harddrive</literal>, <literal>nfs</literal>, <literal>liveimg</literal>, or <literal>url</literal>. The <command>install</command> command and the installation method command must be on separate lines. For example:
@@ -464,7 +400,7 @@ 

  		<section id="sect-kickstart-commands-autopart">

  			<title>autopart (optional) - Automatic Partitioning</title>

  			<para>

- 				Automatically creates partitions: a root (<filename class="partition">/</filename>) partition (1 GB or larger), a <filename class="partition">swap</filename> partition, and an appropriate <filename class="partition">/boot</filename> partition for the architecture. On large enough drives (50&nbsp;GB and larger), this also creates a <filename class="partition">/home</filename> partition.

+ 				Automatically creates partitions: a root (<filename class="partition">/</filename>) partition (10 GB -15GB), a <filename class="partition">swap</filename> partition,(on systems  with less than 8GB RAM) and an appropriate <filename class="partition">/boot</filename> and / or <filename>/boot/efi</filename>partition for the architecture, a <filename class="partition">/home</filename> partition is  created filling the  remaining free space (unless 'I want to  leave free space' option is 'checked' On large drives this  <filename>/home</filename> is  generally  50 GB or more.

We have an entire section describing partition layout, I don't think this paragraph needs to get into it. I'm also not confident that autopart creates a /boot by default - can you verify this?

  			</para>

  			<important>

  				<para>
@@ -535,6 +471,12 @@ 

  						<para>

  							Provides a default system-wide passphrase for all encrypted devices.

  						</para>

+ 				<important>

+                                 <para>

+                                         The ommision of  <filename>--passphrase</filename> will prompt the  user  for a  passphrase. This will not work if <command>inst.commandline</command> or  <command>inst.text</command>  are  used at grub menu.

inst.commandline and inst.text are still interactive methods; if the prompt is not presented to the user, that is a bug. Have you verified this behavior? I do like an admonition to remind readers that a passphrase declaration is required for an unattended install, though.

+                                 </para>

+                         </important>

+ 

  					</listitem>

  				</varlistentry>

  				<varlistentry>
@@ -551,13 +493,19 @@ 

  						<para>

  							Adds a randomly-generated passphrase to each encrypted volume. Store these passphrases in separate files in <filename>/root</filename>, encrypted using the X.509 certificate specified with <option>--escrowcert</option>. This option is only meaningful if <option>--escrowcert</option> is specified.

  						</para>

+ 			important>

+                                 <para>

+                                         The ommision of  <filename>--backuppassphrase</filename> will prompt the  user  for a  passphrase. This will not work if <command>inst.commandline</command> or  <command>inst.text</command>  are  used at grub menu.

+                                 </para>

+                         </important>

+ rsvalidator <replaceable>/pat

We could more succinctly discuss the backup passphrase with the regular passphrase, and there are some xml validity issues here that would also go away if both were in the same admonition.

  					</listitem>

  				</varlistentry>

  				<varlistentry>

  					<term><option>--cipher=</option></term>

  					<listitem>

  						<para>

- 							Specifies which type of encryption will be used if the <application>Anaconda</application> default <systemitem>aes-xts-plain64</systemitem> is not satisfactory. You must use this option together with the <option>--encrypted</option> option; by itself it has no effect. Available types of encryption are listed in the <citetitle>Fedora Security Guide</citetitle>, available at <ulink url="http://docs.fedoraproject.org/" />. Using either <systemitem>aes-xts-plain64</systemitem> or <systemitem>aes-cbc-essiv:sha256</systemitem> is strongly recommended.

+ 							Specifies which type of encryption will be used if the <application>Anaconda</application> default <systemitem>aes-xts-plain64</systemitem> is not satisfactory. You must use this option together with the <option>--encrypted</option> option; by itself it has no effect. Available types of encryption are listed in the <citetitle>Fedora Security Guide</citetitle>, available at <ulink url="http://docs.fedoraproject.org/" />. Using <systemitem>aes-xts-plain64</systemitem>  is strongly recommended.

Do you have a technical justification for removing the aes-cbc-essiv:sha256 recommendation?

  						</para>

Yes, New standard no longer uses defaults to using cbc

  					</listitem>

  				</varlistentry>
@@ -593,19 +541,6 @@ 

  					</listitem>

  				</varlistentry>

  				<varlistentry>

- 					<term><option>--boot-drive=</option></term>

I still see the code for this option in anaconda, do you have a technical reference for removing this list entry?

- 					<listitem>

- 						<para>

- 							Specifies which drive the boot loader should be written to, and therefore which drive the computer will boot from. If you use a multipath device as the boot drive, specify only one member of the device.

- 						</para>

- 						<important>

- 							<para>

- 								The <option>--boot-drive=</option> option is currently being ignored in &PRODUCT; installations on IBM System&nbsp;z systems using the <application>zipl</application> boot loader. When <application>zipl</application> is installed, it determines the boot drive on its own.

- 							</para>

- 						</important>

- 					</listitem>

- 				</varlistentry>

- 				<varlistentry>

  					<term><option>--leavebootorder</option></term>

  					<listitem>

  						<para>
@@ -695,41 +630,6 @@ 

  						</para>

  					</listitem>

  				</varlistentry>

- 				<varlistentry>

- 					<term><option>--default=</option></term>

- 					<listitem>

- 						<para>

- 							Sets the default boot image in the boot loader configuration.

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 				<varlistentry>

- 					<term><option>--extlinux</option></term>

- 					<listitem>

- 						<para>

- 							Use the <application>extlinux</application> boot loader instead of <application>GRUB2</application>. This option only works on systems supported by <application>extlinux</application>.

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 				<varlistentry>

- 					<term><option>--disabled</option></term>

- 					<listitem>

- 						<para>

- 							Do not attempt to install a boot loader. This option overrides all other boot loader configuration; all other boot loader options will be ignored and no boot loader packages will be installed.

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 				<varlistentry>

- 					<term><option>--nombr</option></term>

- 					<listitem>

- 						<para>

- 							Install the boot loader configuration and support files, but do not modify the MBR.

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 			</variablelist>

- 		</section>

- 

revert removing lines 162-195 please.

  		<section id="sect-kickstart-commands-btrfs">

  			<title>btrfs (optional) - Create Btrfs Volume or Subvolume</title>

  			<para>
@@ -1248,18 +1148,8 @@ 

  				</varlistentry>

  				<varlistentry>

  					<term><option>--recommended</option></term>

- 					<listitem>

- 						<para>

- 							Use this option when creating a <systemitem>swap</systemitem> logical volume to determine the size of this volume automatically, based on your system's hardware. For details about the recommended scheme, see <xref linkend="sect-installation-gui-manual-partitioning-recommended" />.

- 						</para>

- 						<important>

- 							<para>

- 								This option can only be used for partitions which result in a file system such as the <filename>/boot</filename> partition and <systemitem>swap</systemitem> space. It can not be used to create partitionsm, LVM physical or logical volumes or RAID members.

- 							</para>

- 						</important>

- 					</listitem>

revert removing lines 204-213 please.

+ 				

  				</varlistentry>

- 				<varlistentry>

this breaks xml validity, please revert.

  					<term><option>--resize</option></term>

  					<listitem>

  						<para>
@@ -1269,9 +1159,8 @@ 

  				</varlistentry>

  				<varlistentry>

  					<term><option>--encrypted</option></term>

- 					<listitem>

  						<para>

- 							Specifies that this logical volume should be encrypted, using the passphrase provided in the <option>--passphrase=</option> option. If you do not specify a passphrase, the installation program will use the default, system-wide passphrase set with the <command>autopart --passphrase</command> command, or stop the installation and prompt you to provide a passphrase if no default is set.

+ This option requires a value for <filename> --passphrase</filename>, whether it is in the  kickstart file or asked of the user during install.

We already said that here.

  						</para>

  					</listitem>

  				</varlistentry>
@@ -1287,12 +1176,12 @@ 

  					<term><option>--cipher=</option></term>

  					<listitem>

  						<para>

- 							Specifies which type of encryption will be used if the <application>Anaconda</application> default <systemitem>aes-xts-plain64</systemitem> is not satisfactory. You must use this option together with the <option>--encrypted</option> option; by itself it has no effect. Available types of encryption are listed in the <citetitle>Fedora Security Guide</citetitle>, available at <ulink url="http://docs.fedoraproject.org/" />. Using either <systemitem>aes-xts-plain64</systemitem> or <systemitem>aes-cbc-essiv:sha256</systemitem> is strongly recommended.

+ 							Specifies which type of encryption will be used if the <application>Anaconda</application> default <systemitem>aes-xts-plain64</systemitem> is not satisfactory. You must use this option together with the <option>--encrypted</option> option; by itself it has no effect. Available types of encryption are listed in the <citetitle>Fedora Security Guide</citetitle>, available at <ulink url="http://docs.fedoraproject.org/" />. Using <systemitem>aes-xts-plain64</systemitem>  is strongly recommended.

For most 'advanced' ciphers mcrypt + bcrypt are needed (not included in the default LIves OR kickstarts)

Is there a technical justification for removing the aes-cbc-essiv:sha256 recommendation? Did you intend to describe requirements and reasons to use ciphers that are not supported by the installation image here?

  						</para>

  					</listitem>

  				</varlistentry>

  				<varlistentry>

- 					<term><option>--escrowcert=<replaceable>URL_of_X.509_certificate</replaceable></option></term>

+ ###					<term><option>--escrowcert=<replaceable>URL_of_X.509_certificate</replaceable></option></term>

This breaks XML and logical document structure by removing the variable part of a varlistentry, please revert.

  					<listitem>

  						<para>

  							Store data encryption keys of all encrypted volumes as files in <filename>/root</filename>, encrypted using the X.509 certificate from the URL specified with <replaceable>URL_of_X.509_certificate</replaceable>. The keys are stored as a separate file for each encrypted volume. This option is only meaningful if <option>--encrypted</option> is specified.
@@ -2648,7 +2537,7 @@ 

  			<programlisting>

  <command>auth [--enablenis | --nisdomain= | --nisserver= | --enableshadow | --enableldap | --enableldapauth | --ldapserver= | --ldapbasedn= | --enableldaptls | --disableldaptls | --enablekrb5 | --krb5realm= | --krb5kdc= | --krb5adminserver= | --enablehesiod | --hesiodlhs= | --hesiodrhs= | --enablesmbauth | --smbservers= | --smbworkgroup= | --enablecache | --passalgo=]</command>

  			</programlisting>

- 			<variablelist>

+ 			<variablelist> 

  				<varlistentry>

  					<term><option>--enablenis</option></term>

  					<listitem>
@@ -2855,7 +2744,7 @@ 

  		<section id="sect-kickstart-commands-pwpolicy">

  			<title>pwpolicy (optional) - Change the Default Password Policy</title>

  			<para>

- 				This command can be used to set custom requirements (policy) such as length and strength for passwords set during the installation - the <systemitem>root</systemitem> password, user passwords and LUKS (disk encryption) password.

+ 				This command can be used to set custom requirements (policy) such as length and strength for passwords set during the installation - the <systemitem>root</systemitem> password, user passwords and LUKS (disk encryption) password. For LUKS Passwords these cahnges are  ONLY for future changes / inputs,  the  previously  set one  (previous  install or earlier in Kickstart file) will be  unaffected by this  option unless <filename>--changesok</filename>  is  used. 

This is good info to add, but your change could be rephrased to be more clear and remove spelling errors.

  			</para>

  			<programlisting>

  <command>pwpolicy <replaceable>name</replaceable> [--minlen=<replaceable>length</replaceable>] [--minquality=<replaceable>quality</replaceable>] [--strict|nostrict] [--emptyok|noempty] [--changesok|nochanges]</command>
@@ -3085,7 +2974,7 @@ 

  		<section id="sect-kickstart-commands-sshkey">

  			<title>sshkey (optional) - Add an Authorized SSH Key</title>

  			<para>

- 				Use this command to add a specified <systemitem>SSH</systemitem> key to an user's <filename>authorized_keys</filename> file. The specified user must either be <systemitem>root</systemitem>, or it must be created in the Kickstart file - either automatically by an installed package, or using <xref linkend="sect-kickstart-commands-user" />.

+ 				Use this command to add a specified <systemitem>SSH</systemitem> key to any  user's <filename>authorized_keys</filename> file. The specified user must either be <systemitem>root</systemitem>, or it must be created in the Kickstart file - either automatically by an installed package, or using <xref linkend="sect-kickstart-commands-user" />.

This is more of a rephrasing for personal preference than an improvement; while this usage of 'an' has fallen out of favor in American English, it is still valid, Please revert.

  			</para>

  			<programlisting><command>sshkey --username=<replaceable>user</replaceable> "<replaceable>ssh_key</replaceable>"</command></programlisting>

  			<para>
@@ -3101,7 +2990,7 @@ 

  					</listitem>

  				</varlistentry>

  			</variablelist>

- 		</section>

+ 		</section>t

typo, please revert.

  

  		<section id="sect-kickstart-commands-user">

  			<title>user (optional) - Create User Account</title>
@@ -3224,10 +3113,7 @@ 

  					<term><option>--autoscreenshot</option></term>

  					<listitem>

  						<para>

- 							Take a screenshot at every step during installation. These screenshots are stored in <filename class="directory">/tmp/anaconda-screenshots</filename> during the installation, and after the installation finishes you can find them in <filename class="directory">/root/anaconda-screenshots</filename>.

- 						</para>

- 						<para>

- 							Each screen is only captured right before the installer switches to the next one. This is important, because if you do not use all required Kickstart options and the installation therefore does not begin automatically, you can go to the screens which were not automatically configured, perform any configuration you want. Then, when you press <guilabel>Done</guilabel> to continue, the screen will be captured including the configuration you just provided.

+ 							Take a screenshot at every step during installation. These screenshots are stored in <filename class="directory">/tmp/anaconda-screenshots</filename> during the installation, and after the installation finishes you can find them in <filename class="directory">/root/anaconda-screenshots</filename>.Each screen is only captured right before the installer switches to the next one.

We're losing some of the copy's utility here; you've removed the part that explains to the reader how to make the --autoscreenshot option useful. Unless there's a technical change to the option, please revert.

  						</para>

first off its already explained here: sect-kickstart-commands-installation-environment
secondly it seems well out of place in this section.

  					</listitem>

  				</varlistentry>
@@ -3237,13 +3123,8 @@ 

  		<section id="sect-kickstart-commands-cmdline">

  			<title>cmdline (optional) - Perform Installation in Command Line Mode</title>

  			<para>

- 				Perform the installation in a completely non-interactive command line mode. Any prompts for interaction halts the install. This mode is useful on IBM System&nbsp;z systems with the x3270 terminal.

+ 				Perform the installation in a completely non-interactive command line mode. Any prompts for interaction halts the install. This mode is useful on IBM System&nbsp;z systems with the x3270 terminal and  large scale  deployments with  ansible-ized post  install host master configuration.

  			</para>

- 			<important>

- 				<para>

- 					For a fully automatic installation, you must either specify one of the available modes (<command>graphical</command>, <command>text</command>, or <command>cmdline</command>) in the Kickstart file, or you must use the <option>console=</option> boot option as described in <xref linkend="sect-boot-options-display" />. Otherwise the system will halt and ask you to choose a mode.

this admonition is still valid, please revert.

- 				</para>

- 			</important>

  		</section>

  

  		<section id="sect-kickstart-commands-graphical">
@@ -3445,9 +3326,6 @@ 

  				<application>Kdump</application> is a kernel crash dumping mechanism that allows you to save the contents of the system's memory for later analysis. It relies on <application>kexec</application>, which can be used to start a Linux kernel from the context of another kernel without rebooting the system and preserve the contents of the first kernel memory that would otherwise be lost.

  			</para>

  			<para>

- 				In case of a system crash, <application>kexec</application> starts a second kernel (a <firstterm>capture kernel</firstterm>). This capture kernel resides in a reserved part of the system memory that is inaccessible to the main kernel. <application>Kdump</application> then captures the contents of the crashed kernel's memory (a <firstterm>crash dump</firstterm>) and saves it to a specified location. This location can not be configured using Kickstart; it must be specified after the installation by editing the <filename>/etc/kdump.conf</filename> configuration file.

This info is valid and appropriate, please revert it's removal.

- 			</para>

It's already thrice mentioned previously .

- 			<para>

  				Available options are:

  			</para>

  			<variablelist>
@@ -3485,16 +3363,7 @@ 

  						</para>

  					</listitem>

  				</varlistentry>

- 				<varlistentry>

- 					<term><option>--enablefadump</option></term>

- 					<listitem>

- 						<para>

- 							Enable firmware-assisted dumping on systems which allow it (notably IBM Power&nbsp;Systems servers).

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 			</variablelist>

- 		</section>

This breaks XML; if the kickstart option is no longer valid, you should only remove the <varlistentry> block. If it is deprecated, can you please cite a reference? It's usually best to make such references in a commit message.

+ 	

Notably IBM Systems, this is a RHEL use case NOT Fedora....

  

  		<section id="sect-kickstart-commands-firstboot">

  			<title>firstboot (optional) - Enable or Disable Initial Setup</title>
@@ -3535,39 +3404,20 @@ 

  			<para>

  				Halt the system after the installation has successfully completed. This is similar to a manual installation, where after the installation finishes, the installer displays a message and waits for the user to press a key before rebooting. During a Kickstart installation, if no completion method is specified, this option is used as the default.

  			</para>

- 			<para>

- 				For other completion methods, see the <command>poweroff</command>, <command>reboot</command>, and <command>shutdown</command> commands.

- 			</para>

- 		</section>

+ 			</section>

This info is valid, please revert it's removal.

  

Don't see need for a redundant mention of same commands shown just below it . It's akin to a nag bomb.

  		<section id="sect-kickstart-commands-poweroff">

  			<title>poweroff (optional) - Power Off After Installation</title>

  			<para>

  				Shut down and power off the system after the installation has successfully completed.

  			</para>

- 			<note>

- 				<para>

- 					The <command>poweroff</command> command is highly dependent on the system hardware in use. Specifically, certain hardware components such as the BIOS, APM (advanced power management), and ACPI (advanced configuration and power interface) must be able to interact with the system kernel. Consult your hardware documentation for more information on you system's APM/ACPI abilities.

- 				</para>

- 			</note>

- 			<para>

- 				For other completion methods, see the <command>halt</command>, <command>reboot</command>, and <command>shutdown</command> Kickstart commands.

Needless redirects could still be removed

The information is accurate and inappropriate; I don't know what you mean by 'redirect' in this context, or why you are removing these lines.

...appropriate. It is not inappropriate information.

- 			</para>

- 		</section>

+ 			</section>

  

  		<section id="sect-kickstart-commands-reboot">

  			<title>reboot (optional) - Reboot After Installation</title>

  			<para>

- 				Reboot after the installation is successfully completed. If you are installing &PRODUCT; on IBM System&nbsp;z in command line mode (using <xref linkend="sect-kickstart-commands-cmdline" />), this command is necessary for a fully automated installation.

+ 				Reboot after the installation is successfully completed. 

s390 Fedora does exist, please revert.

  			</para>

- 			<para>

- 				For other completion methods, see the <command>halt</command>, <command>poweroff</command>, and <command>shutdown</command> Kickstart options.

- 			</para>

- 			<important>

- 				<para>

- 					Use of the <command>reboot</command> command <emphasis>may</emphasis> result in an endless installation loop, depending on the installation media and method.

- 				</para>

- 			</important>

  			<variablelist>

  				<varlistentry>

  					<term><option>--eject</option></term>
@@ -3577,15 +3427,7 @@ 

  						</para>

  					</listitem>

  				</varlistentry>

- 				<varlistentry>

- 					<term><option>--kexec</option></term>

- 					<listitem>

- 						<para>

- 							Use this option to reboot into the new system using the <systemitem>kexec</systemitem> kernel switching mechanism instead of a full reboot, bypassing the BIOS/Firmware and boot loader.

- 						</para>

- 					</listitem>

- 				</varlistentry>

- 			</variablelist>

+ 				

Can you provide a reference showing the kexec option has been removed from anaconda?

  		</section>

Per chat in #anaconda, team stated its mostly for RHEL NOT Fedora and is discouraged.

  

  		<section id="sect-kickstart-commands-shutdown">
@@ -3593,35 +3435,12 @@ 

  			<para>

  				Shut down the system after the installation has successfully completed.

  			</para>

- 			<para>

- 				For other completion methods, see the <command>halt</command>, <command>poweroff</command>, and <command>reboot</command> Kickstart options.

- 			</para>

- 		</section>

- 

- 	</section>

- 

- 	<section id="sect-kickstart-commands-addon">

- 		<title>%addon (optional) - Include an Anaconda Add-on</title>

- 		<para>

- 			You can expand the basic <application>Anaconda</application> and Kickstart functionality by using custom add-ons specified using the <command>%addon</command> section.

- 		</para>

- 		<para>

- 			To use an add-on in your Kickstart file, add the <command>%addon <replaceable>addon_name</replaceable> <replaceable>options</replaceable></command> command. The section must be closed with an <command>%end</command> statement. For example, to use the <application>Kdump</application> add-on, which is included by default on some installations, use the following block:

- 		</para>

- 		<programlisting><command>%addon com_redhat_kdump --enable --reserve-mb=128</command><command>%end</command>

- 		</programlisting>

- 		<para>

- 			The <command>%addon</command> section does not have any options of its own; all options depend on the add-on being used.

- 		</para>

- 		<para>

- 			For more information about <application>Anaconda</application> add-ons, see the <ulink url="https://vpodzime.fedorapeople.org/anaconda-addon-development-guide/">Fedora Anaconda Addon Development Guide</ulink>.

- 		</para>

Anaconda plugins are a real thing, please revert removing this section.

  	</section>

Again was advised this was mostly RHEL NOT Fedora

  

  	<section id="sect-kickstart-commands-anaconda">

  		<title>%anaconda (optional) - Additional Anaconda Configuration</title>

  		<para>

- 			This section, introduced in &PRODUCT; 22, is used to specify additional configuration options for the installer. Commands inside this section only control the behavior during installation, not on the installed system. The only command currently available inside this section is <xref linkend="sect-kickstart-commands-pwpolicy" />. The <command>%anaconda</command> section must end with <literal>%end</literal>.

+ 			This section, originally introduced in &PRODUCT; 22, is used to specify additional configuration options for the installer. Commands inside this section only control the behavior during installation, not on the installed system. The only command currently available inside this section is <xref linkend="sect-kickstart-commands-pwpolicy" />. The <command>%anaconda</command> section must end with <literal>%end</literal>.

This is an unnecessary change, please revert.

  		</para>

  		<para>

  			In interactive installations (using the graphical or text interface), the <filename>/usr/share/anaconda/interactive-defaults.ks</filename> file contains the default <command>%anaconda</command> section. To change the defaults, you must create a <filename>product.img</filename> file with a Kickstart file replacing the default one, and pass this file to <application>Anaconda</application> using a boot option.
@@ -3700,9 +3519,9 @@ 

  					</para>

  					<programlisting>

  <command>%packages</command>

- @X Window System

- @Desktop

- @Sound and Video

+ @^X Window System

+ @^Desktop

+ @^Sound and Video

  <command>%end</command>

  					</programlisting>

  					<para>
@@ -3740,7 +3559,7 @@ 

  					</para>

  					<programlisting>

  <command>%packages</command>

- -@Graphical Internet

+ -@^Graphical Internet

  -autofs

  -ipa*fonts

  <command>%end</command>
@@ -3750,7 +3569,7 @@ 

  		</variablelist>

  		<important>

  			<para>

- 				Installing all available packages using only <literal>*</literal> in a Kickstart file is not supported, even if you exclude the <literal>@Conflicts (<replaceable>variant</replaceable>)</literal> group.

+ 				Installing all available packages using only <literal>*</literal> in a Kickstart file is not supported, even if you exclude the <literal>@^Conflicts (<replaceable>variant</replaceable>)</literal> group.

  			</para>

  		</important>

  		<para>

file modified
+2 -11
@@ -6,16 +6,7 @@ 

  <section id="sect-installation-gui-language-support">

  	<title>Language Support</title>

  	<para>

- 		The <guilabel>Language Support</guilabel> screen allows you to configure language settings for your system. The default language is determined by your selection in <xref linkend="sect-installation-gui-welcome" /> and support for this language can not be removed. You can only add additional languages, which will be available on the installed system - not during the installation.

- 	</para>

- 	<para>

- 		If you want to change the default language, or the language used during the installation, you must reboot your system, start the installer again, and select a different language in <xref linkend="sect-installation-gui-welcome" />.

- 	</para>

- 	<note>

- 		<para>

- 			Adding support for another language does not automatically configure the corresponding keyboard layout. Layouts are a separate setting configured in <xref linkend="sect-installation-gui-keyboard-layout" />.

- 		</para>

- 	</note>

+ 		The <guilabel>Language Support</guilabel> screen allows you to configure language settings for your system. The default language is determined by your selection in <xref linkend="sect-installation-gui-welcome" /> and support for this language can not be removed. You can only add additional languages, which will be available on the installed system  and during the installation. This requires using the  language switcher after adding the  additional language(s).

  	<figure>

  		<title>Language Support</title>

  		<mediaobject>
@@ -30,7 +21,7 @@ 

  		</mediaobject>

  	</figure>

  	<para>

- 		The left panel contains a list of available language groups such as <guilabel>English</guilabel> or <guilabel>Bulgarian</guilabel>. If at least one language from a group is selected, a check mark will be displayed next to the group, and the list entry will be highlighted. This allows you to easily see which languages you have configured support for.

+ 		The left panel contains a list of available language groups such as <guilabel>English</guilabel> or <guilabel>Bulgarian</guilabel>. If at least one language from a group is selected, a check mark will be displayed next to the group, and the list entry will be highlighted. This allows you to easily see which languages you have configured support for.  Move the  desired default language to the top (even if not highlighted) the topmost  language is made the default on the installed system.

This is an unnecessary change, please revert.

  	</para>

  	<para>

  		To add support for one or more additional languages, click a group in the left panel, and then select one or more regional variations in the right panel using check boxes next to list entries. Repeat this process for all languages you want to install support for.

@@ -9,19 +9,7 @@ 

  		<para>

  			This appendix is intended for users with previous Linux experience. If you are a new user, you may want to install using minimal boot media or the distribution DVD instead.

  		</para>

- 	</note>

- 	<!--

- 	<remark>

- 		Do we really need to warn about blowing away the system? The suggested config could simply boot an interactive installer, point to kickstarts.  If you write out a custom kickstart, you shouldn't be surprised that it destroys filesystems like you told it to.

- 	</remark>

- 

- 	<warning>

- 		<para>

- 			The instructions in this appendix configures an automated install server. The default configuration includes destruction of all existing data on all disks for hosts that install using this method. This is often different from other network install server configurations which may provide for an interactive installation experience.

- 		</para>

- 	</warning>

- 	-->

I'm going to defer to Petr on removing or using this warning; this change is a good example of why smaller pull requests are better.
Also, you removed a </note> that was not part of your intended change.

- 	<section id="pxe-overview">

+ 		<section id="pxe-overview">

  		<title>PXE Installation Overview</title>

  		<para>

  			Preboot Execution Environment, or PXE, is a techonology that allows computers to boot directly from resources provided over the network.  Installing Fedora over the network means you don't have to create media, and you can install to multiple computers or virtual machine simultaneously.  The process involves a number of components and features working together to provide the resources required.
@@ -62,7 +50,11 @@ 

  				A Fedora repository must be available for the installation.  The example in this section uses the public Fedora mirrors as the repository source, but you can also use a repo on the local network provided by NFS, FTP, or HTTP. Repositories can be configured using the <option>inst.repo=</option> boot option; see <xref linkend="sect-boot-options-sources" /> for details.

  			</para>

  		</formalpara>

- 		<remark>A link to mirrormanager and some instructions to other guides too.  All the elaboration on installation methods might be going to far, but we can ref. --Pete</remark>

+ 		<para> Examples:

This would be better as a <simplelist> or <itemizedlist>; it will get formatted more appropriately that way.

+ 			inst.repo=http://mirrors.fedoraproject.org/mirrorlist?repo=fedora-$arch=$basearch

+ 			inst.repo=nfs://192.168.1.100/fedora/linux//23/Live/x86_64/os

+ 			inst.repo=ftp://mirror.cc.vt.edu/fedora/linux/releases/24/x86_64/Server/os

+ 		</para>

  	</section>

  	<section id="pxe-dhcpd">

  		<title>DHCP Server Configuration</title>
@@ -194,7 +186,7 @@ 

  						</para>

  						<screen>

  <command>mkdir -p <filename class="directory" >/var/lib/tftpboot/uefi</filename></command>

- <command>cp <filename>/tmp/fedora/boot/efi/EFI/fedora/{shim.efi,grubx64.efi}</filename> <filename>/var/lib/tftpboot/uefi/</filename></command>

+ <command>cp <filename>/tmp/fedora/boot/efi/EFI/fedora/{shim,efi,grubx64.efi}</filename> <filename>/var/lib/tftpboot/uefi/</filename></command>

  						</screen>

  					</step>

  				</substeps>
@@ -304,7 +296,7 @@ 

  			For more complex environments, &PRODUCT; offers the <package>cobbler</package> installation server.   Tasks like managing kickstart configurtations, coordinating repositories, maintaining dns records, dhcp servers, and even puppet manifests are effectively automated by <package>cobbler</package>.

  		</para>

  		<para>

- 			While levaraging all of the features provided by cobbler can be relatively simple, the full functionality of this powerful tool is too broad to be documented in this guide.  The cobbler community provides excellent documentation at <ulink url="http://www.cobblerd.org/manuals/2.6.0/" /> to accompany the packages in the Fedora repository.

+ 			While leveraging all of the features provided by cobbler can be relatively simple, the full functionality of this powerful tool is too broad to be documented in this guide.  The cobbler community provides excellent documentation at <ulink url="http://www.cobblerd.org/manuals/2.6.0/" /> to accompany the packages in the Fedora repository.

  		</para>

  	</section>

  </chapter>

  • Version Bump
  • Cleaned up Formatting on MANY files
  • Removed nearly 200 lines of duplicated / deprecated / outdated info from Kickstart_Syntax_Reference -- however much more interlinking could be done and would largely reduce the size of that file.

Needless redirects could still be removed

For most 'advanced' ciphers mcrypt + bcrypt are needed (not included in the default LIves OR kickstarts)

Appending to the end here, after the 'or', makes it read as if USB drives are an example of a network location. How about ~"an ISO image.... on either optical or USB disk?"

This is just an example, it seems gratuitous to change it.

This reads to me as if the inst.gpt option is commonly marked as UEFI+CSM or LEGACY. Can you restructure this?

This is good info to add here, but the grammar could be more clear. Can you please restructure this sentence?

This option has a different default behavior depending on the available memory, and we're describing the behavior and how to change it in each circumstance equally. I don't think removing the clause for disabling the default where <2GB of memory is available adds value here.

We're linking to the docs for kdump in both kickstart and GUI processes, we should stick to describing kdump's function and parameters there.

GRUB gives you the option of both a function key and ctl+x to boot; in my experience, ctl+x works universally but the function key does not on some systems. ctl+x also aligns with the downstream RHEL Installation Guide.

A good addition, but a few thoughts on presentation:

  • We shouldn't capitalize for emphasis. If the concept is important enough to call special attention to it,
    an admonition would be more appropriate, ie <note>, <important>, or <warning>. If the idea does not warrant
    an admonition, we probably don't need to emphasize it more than an <emphasis> tag around a phrase.
  • 'disk layout' and 'disk size' doesn't need to be pluralized, you could more succinctly say 'disk layout and size'.
  • s/awkile/awhile/

I wouldn't qualify an "Are you sure you want swap?" type message with blocking filesystem layout error messages, to the point that I actually had to reread this several times to get what you were communicating. This should be rephrased to be more clear, or maybe even just left as is.

Good addition! DocBook also has a <keycombo> tag you can use to wrap a set of <keycap> tags, but it isn't imperative.

I actually prefer the brevity you've added to this sentence, but I don't think we should make this change for a different reason. The change is minor and doesn't affect what the sentence communicates, but the act of changing it will require all translations of the sentence be performed again. It adds a deceptively large amount of work for such a small change.

brevity vs l10n team effort concerns apply here too.

I don't see thinp as 'experimental' at this point. Is there a reference we can cite here?

This is a good point to add, but I think we can be more positive in delivery. It would be best to have an article, list discussion, or document to point to , ie "For information on the features and limitations of btrfs, refer to..." and implicitly recommend that the reader make a decision for themselves.

Because we're working with XML, the '<' character should be represented with it's entity, &lt'. There's a list of such things and more info at http://www.docbook.org/tdg/en/html/ch01.html#s-entities .

hmm... this could be made more succinct if you clarified in the first sentence that XFS cannot be shrunk, only grown.

how about ..."or if you use a debug kernel, as debug symbols" ? It might be nice to give a rough estimate too, do you know how much space is consumed with the default (installonly_limit) number of debug kernels installed?

Now that you bring attention to it, I think the technology has progressed to the point that we can defer with this recommendation. Since changing this would require retranslation, I think it would be better to research the validity of the recommendation before changing the copy.

Good catch! We could save some reading time by mentioning /boot/efi with /boot, instead of adding a new paragraph.

That is in fact the only time it is used, for a proper UEFI system gpt is already in place.

I'm wary of describing the default value here; If you use the installer you'll discover the info on your own, and if we cite that here we'll have to verify the citation for every release.

s/luie/lieu/ , and there's an open parenthesis without it's close.

So link only to the kdump section, and drop the ks link, with a bit more 'why would I use / need to use this' ?

So a 'nothing to see here, move along' ?

Never seen or used the Ctl+X myself but sure, not sure the RHEL part should really dictate our docs that much tho tbh.

The object of your sentence is not clear, it needs to be stated differently.

No, don't make changes to this line at all. This is only a list of kickstart options, and kickstart itself is documented elsewhere.

Remove '<F12><F12><F12>' . I'm assuming it's an accident.

It seems to read better with the brevity, hence I question if the l10n hit might be worth it on this one.

I agree that it reads better, but no, it isn't worth it. You're asking at least one and probably two people from each of dozens of language teams to review and and translate the string, there isn't enough value in the added brevity to justify that.

Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a <note> admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic.

Good point about wifi! I think there's a Workstation netinstall now; if there's wifi support in that, we should instead use a <note> admonition to warn that only the Server image does not have wifi, and rephrase this general description of the netistall to be flavor-agnostic.

This section describes interacting with a tmux window, your edits to the keycombos are incorrect and should be reverted.

This entire statement seems incorrect - doesn't the installer ask you about language and layout before anything else, continue the installation using those settings, and install a system with the same settings?

This file isn't actually published to the site, it's used by anaconda for inline help. We keep it in this repo because other content overlaps, and anacondas help files are generated from the installation guide. In that context, it doesn't make sense to make this change, please revert.

Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist?

Is this only a rephrasing, or does the Manual/Automatic dialog element no longer exist?

This is mostly a general observation that memory constraints have a performance impact, I don't think we need to make that observation here.

We don't need to point out that the UI element that is highlighted when the dialog opens will be the option chosen unless specified otherwise.

This change doesn't merit retranslation, please revert.

This is just whitespace added to the end of the line, I think. Not a big problem or a blocker to a merge, but as a practice you should be careful about leaking superfluous changes into your commits.

/usr/bin/pykickstartexists, and is written in python3. Please revert this change.

This set of changes serves no purpose, please revert.

The pykickstart package provides /usr/bin/ksvalidator, python3-kickstart is strictly python modules. Please revert.

This is a duplicate pair of lines, please revert.

We have an entire section describing partition layout, I don't think this paragraph needs to get into it. I'm also not confident that autopart creates a /boot by default - can you verify this?

inst.commandline and inst.text are still interactive methods; if the prompt is not presented to the user, that is a bug. Have you verified this behavior? I do like an admonition to remind readers that a passphrase declaration is required for an unattended install, though.

We could more succinctly discuss the backup passphrase with the regular passphrase, and there are some xml validity issues here that would also go away if both were in the same admonition.

Do you have a technical justification for removing the aes-cbc-essiv:sha256 recommendation?

I still see the code for this option in anaconda, do you have a technical reference for removing this list entry?

this breaks xml validity, please revert.

revert removing lines 204-213 please.

revert removing lines 162-195 please.

Is there a technical justification for removing the aes-cbc-essiv:sha256 recommendation? Did you intend to describe requirements and reasons to use ciphers that are not supported by the installation image here?

This breaks XML and logical document structure by removing the variable part of a varlistentry, please revert.

This is good info to add, but your change could be rephrased to be more clear and remove spelling errors.

This is more of a rephrasing for personal preference than an improvement; while this usage of 'an' has fallen out of favor in American English, it is still valid, Please revert.

We're losing some of the copy's utility here; you've removed the part that explains to the reader how to make the --autoscreenshot option useful. Unless there's a technical change to the option, please revert.

this admonition is still valid, please revert.

This info is valid and appropriate, please revert it's removal.

This breaks XML; if the kickstart option is no longer valid, you should only remove the <varlistentry> block. If it is deprecated, can you please cite a reference? It's usually best to make such references in a commit message.

This info is valid, please revert it's removal.

The information is accurate and inappropriate; I don't know what you mean by 'redirect' in this context, or why you are removing these lines.

...appropriate. It is not inappropriate information.

s390 Fedora does exist, please revert.

Can you provide a reference showing the kexec option has been removed from anaconda?

Anaconda plugins are a real thing, please revert removing this section.

This is an unnecessary change, please revert.

This is an unnecessary change, please revert.

I'm going to defer to Petr on removing or using this warning; this change is a good example of why smaller pull requests are better.
Also, you removed a </note> that was not part of your intended change.

This would be better as a <simplelist> or <itemizedlist>; it will get formatted more appropriately that way.

Thanks for the review, Corey! I've reviewed your edits and made some comments in Pagure. However, I think this is too many changes to effectively handle in a single pull request. I'd like to move forward with a slightly different workflow for you:

  • Create a branch off of your master branch with these changes,
    for example, "kdump".
  • Make a series of related changes in that branch; in our example,
    that would be all of the changes in the kickstart and GUI sections that you've suggested
    for kdump related topics.
  • Send a pull request for that set of changes.
  • Review and repeat with the next related set of changes.

It will be much easier for us to manage our time investment with smaller pieces, and easier for others to participate in maintaining the document. Please try this approach as you work through the comments.

Pull-Request has been closed by immanetize

7 years ago

Just noticed that will fix it up. It's totally outdated.

auto does not auto select a value anymore, except on server.

Yes, New standard no longer uses defaults to using cbc

first off its already explained here: sect-kickstart-commands-installation-environment
secondly it seems well out of place in this section.

It's already thrice mentioned previously .

Notably IBM Systems, this is a RHEL use case NOT Fedora....

Don't see need for a redundant mention of same commands shown just below it . It's akin to a nag bomb.

Per chat in #anaconda, team stated its mostly for RHEL NOT Fedora and is discouraged.

Again was advised this was mostly RHEL NOT Fedora