PR#22: Text Message to be echoed in bashrc to make the Installer more accesible. - i3-sig/Fedora-i3-Spin

i3-sig / Fedora-i3-Spin

#22 Text Message to be echoed in bashrc to make the Installer more accesible.

Merged 4 years ago by x3mboy. Opened 4 years ago by nasirhm.

i3-sig/ nasirhm/Fedora-i3-Spin text_message_bashrc into master

Text Message to be echoed in bashrc

nasirhm • 4 years ago

5e4ef1d

fedora-live-i3.ks

file modified

+4 -1

		`@@ -47,13 +47,16 @@`
		`# and mark it as executable (new Xfce security feature)`
		`chmod +x /home/liveuser/Desktop/liveinst.desktop`

		`- # this goes at the end after all other changes.`
		`+ # this goes at the end after all other changes.`
		`chown -R liveuser:liveuser /home/liveuser`
		`restorecon -R /home/liveuser`

		`# setting the wallpaper`
		`echo "/usr/bin/feh --bg-scale /usr/share/backgrounds/default.png" >> /home/liveuser/.profile`

		`+ # echoing type liveinst to start the installer`
		`+ echo "echo 'Please type liveinst and press Enter to start the installer'" >> /home/liveuser/.bashrc`
		`+`
		`EOF`

		`%end`

flat-i3.ks

file modified

+4 -1

		`@@ -364,13 +364,16 @@`
		`# and mark it as executable (new Xfce security feature)`
		`chmod +x /home/liveuser/Desktop/liveinst.desktop`

		`- # this goes at the end after all other changes.`
		`+ # this goes at the end after all other changes.`
		`chown -R liveuser:liveuser /home/liveuser`
		`restorecon -R /home/liveuser`

		`# setting the wallpaper`
		`echo "/usr/bin/feh --bg-scale /usr/share/backgrounds/default.png" >> /home/liveuser/.profile`

		`+ # echoing type liveinst to start the installer`
		`+ echo "echo 'Please type liveinst and press Enter to start the installer'" >> /home/liveuser/.bashrc`
		`+`
		`EOF`

		`%end`

nasirhm commented 4 years ago

Added an echo statement in .bashrc for Liveuser to make it easier and accessible for people using the SIG to open the installer.

It'll be executed everytime, the user creates an interactive terminal session with bash (default) on Terminal

Currently, The message displays:
Please type liveinst and press Enter to start the installer.

Metadata Update from @jflory7:
- Pull-request tagged with: type - kickstart

4 years ago

jflory7 commented 4 years ago

The content of the change itself looks good to me. +1!

I have one question though. Is there a way we can define this just once in the kickstarts? Or is there a way that one kickstart can "inherit" the other as a base? My only thought would be that is nice if we can avoid repetition of similar instructions across multiple files. This increases the likelihood of making a change to one file and forgetting to change it in another.

I am not a kickstart expert though, so not sure if there is a clean way of doing this, or if we should revisit in a future PR.

nasirhm commented 4 years ago

The content of the change itself looks good to me. +1!

Thank you :)

I have one question though. Is there a way we can define this just once in the kickstarts? Or is there a way that one kickstart can "inherit" the other as a base? My only thought would be that is nice if we can avoid repetition of similar instructions across multiple files. This increases the likelihood of making a change to one file and forgetting to change it in another.

We're modified it only on one Kickstart (fedora-live-i3.ks), the other one is actually the flattened one.

I am not a kickstart expert though, so not sure if there is a clean way of doing this, or if we should revisit in a future PR.

There would be other ways to do it, I tried doing them with modifying the defaults. If there are other clean ways of doing it, we can revisit it in a next future PR though.