d40315b
@@ -52,6 +52,9 @@
for e in ["bash", "pkg-config", "zcat", "kinit", "krb5kdc", "kdb5_util",
"kadmin.local", "kdb5_ldap_util", "slapd", "slapadd",
"ldapmodify", "valgrind"]:
+ if e == "valgrind" and not args['valgrind_cmd'].startswith('valgrind'):
+ continue
+
check_exec(e)
testdir = args['path']
Only run the check_exec on Valgrind when present as the prefix to the --valgrind-cmd argument. This lets us run the test suite without Valgrind via:
./tests/runtests.py --valgrind-cmd ""
Signed-off-by: Alexander Scheel <ascheel@redhat.com>
As a nice side effect too, if the user specifies an explicit path or an otherwise non-standard name, we assume they know what they're doing. But if they're just providing additional args, we still sanity check that Valgrind exists on the path.
To clarify: you can already run the test suite without Valgrind this way -- this just skips the check_exec so you can run the test suite without Valgrind installed.
check_exec
Commit f91e23f fixes this pull-request
Pull-Request has been merged by rharwood
cipherboy
commented 5 years ago
Only run the check_exec on Valgrind when present as the prefix to the
--valgrind-cmd argument. This lets us run the test suite without
Valgrind via:
Signed-off-by: Alexander Scheel <ascheel@redhat.com>