PR#204: Fix error handling in gp_config_from_dir -

gssproxy

#204 Fix error handling in gp_config_from_dir

Merged Nov 15, 2017 by cipherboy. Opened Jul 12, 2017 by cipherboy.

cipherboy/gssproxy error_handling into master

cipherboy commented Jul 12, 2017

This is a bugfix when handling errors in gp_config_from_dir. Per docs, ref_array_getlen returns a status code (0/EINVAL) and not the length of the array; the second parameter, i, is assigned the length of the array. Thus i >= 0 and len == 0, so i >= len and the for loop is never triggered.

Second, due to the implementation, error_list is a list of pointers to error message strings. This does not need to be freed as ini_config_augment handles this for us.

cipherboy commented Jul 12, 2017

Would you accept GPDEBUG() changed to GPERROR() or fprintf(stderr, ...) as well? I feel that GPERROR() is more fitting in this case, as GPDEBUG() will not work when run as a daemon due to gp_debug not being set. If an error happens while loading the config file, gp_debug_toggle() will not have been called and with the current implementation of gp_debug_args(), gp_debug will be at its default value of zero.