Issue #132: build doesn't always expand templates in the systemd unit - gssproxy

gssproxy

#132 build doesn't always expand templates in the systemd unit

Closed: Fixed Opened Jan 9, 2015 by grawity.

After compiling with ./configure --prefix=/usr, gssproxy.service had:

[Unit]
Description=GSSAPI Proxy Daemon
# GSSPROXY will not be started until syslog is
After=syslog.target
Before=nfs-secure.service nfs-secure-server.service
Requires=proc-fs-nfsd.mount
[Service]
ExecStart=${exec_prefix}/sbin/gssproxy -D
# These two should be used with traditional UNIX forking daemons
# consult systemd.service(5) for more details
Type=forking
PIDFile=${prefix}/var/run/gssproxy.pid
[Install]
WantedBy=multi-user.target

Note the leftover templates in ExecStart= and PIDFile=.

This is only a minor problem, as it went away after I specified the proper Arch ./configure options (--sbindir=/usr/bin --localstatedir=/var), but it still looks like a glitch in the build process.

simo commented Jan 10, 2015

Proposed patch
0001-Fix-variable-replacemrnt-in-non-config-files.patch

simo commented Jan 10, 2015

Thanks for bringing this one up.
I had noticed some issues with the subsititutions earlier but never really found the time to deal with as the Fedora bvuild system also masked the problem the same way you did by explicitly defining some of the variables.

The attached patch should address the issue both for the systemd unit file and the example files.

Can you confirm it fixes it for you ?
(Note the files are not generate anymore at configure time but at build time)

grawity commented Jan 10, 2015

Yes, it now generates a normal gssproxy.service.

simo commented Mar 26, 2015

Fixed in:
72052a8
8c09bbb

Metadata Update from @grawity:
- Issue assigned to simo
- Issue set to the milestone: 2015 March

Feb 28, 2017

simo commented Nov 15, 2017

Commit 4dd29f4b fixes this issue

simo commented Nov 15, 2017

Commit 72052a86 fixes this issue