PR#97: Extract message from its envelope. - greenwave

greenwave

#97 Extract message from its envelope.

Merged 3 years ago by ralph. Opened 3 years ago by ralph.

envelope into master

Ralph Bean • 3 years ago

758818d

file modified

		`@@ -68,6 +68,7 @@`
		`Args:`
		`message (munch.Munch): A fedmsg about a new result.`
		`"""`
		`+ message = message.get('body', message)`
		`log.debug('Processing message "%s"', message)`
		`self._invalidate_cache(message)`
		`self._publish_decision_changes(message)`

ralph commented 3 years ago

I ran into these in our stg container.

The message is in a little envelope, and we have to take it out.

mjia commented 3 years ago

:thumbsup:

Pull-Request has been merged by ralph

3 years ago

dcallagh commented 3 years ago

Hmm just wondering why there isn't a corresponding test change?

Is this happening at a layer outside what we are testing?

mjia commented 3 years ago

Yeah, I didn't realize that the message is inside body. I guess I was misled by this example

http://fedora-fedmsg.readthedocs.io/en/latest/topics.html#taskotron-result-new

I think we also need to update the waiverdb consumer with this change and I'll create a new PR and fix the tests to use the right format of the message.

mjia commented 3 years ago

See #99