#66 Set an Access-Control-Allow-Origin header to the /decision endpoint
Closed by ralph. Opened by pingou.
pingou/greenwave cors_header  into  master

Download 66.patch

This header is added if the configuration file contains a CORS_URL and
add supports AJAX support for this endpoint.

Relates https://pagure.io/greenwave/issue/65

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

Going to update the rpm with this PR so we can test it in stg :)

2 new commits added

  • Set an Access-Control-Allow-Origin header to the /decision endpoint
  • Create a custom FedoraAtomicCi rule

I guess we could just set resp.headers['Access-Control-Allow-Origin'] = '*' which will allow all the domains.

So as it is still doesn't work, debugging this more

2 new commits added

  • Set an Access-Control-Allow-Origin header to the /decision endpoint
  • Create a custom FedoraAtomicCi rule

This is more thoroughly tested and afaict it works, let's see if staging agrees :)

https://bodhi.stg.fedoraproject.org/updates/cpio-2.12-5.fc26 is no longer failing to contact bodhi :)

2 new commits added

  • Set an Access-Control-Allow-Origin header to the /decision endpoint
  • Create a custom FedoraAtomicCi rule

This introduces a flake8 error (needs an extra newline after the @api.route('/decision', methods=['OPTIONS']) method definition). And I guess it needs rebasing since it is also pulling in the FedoraAtomicCiRule patch.

But apart from that, :+1: from me. Thanks for the patch :-)

Merged. See ee3e236.

Pull-Request has been closed by ralph

Metadata