greenwave

#595 redhat-container-image subject now queries both itself and koji_build
Merged by vmaljulin. Opened by vmaljulin.
vmaljulin/greenwave RHELWF-1569  into  master

Download 595.patch

JIRA: RHELWF-1569

item should be "sha256:..." and nvr field should contain the NVR.

rebased onto c370c9c19e555bfa6bb904a9a1cf0bc050fb4571

rebased onto 0cdc39f9dd575e8002a9173af04c6c5fac491c37

Updated, rebased, all tests are passing now.
@lholecek please review.

Why was this changed? This is for different subject type (container-image, not redhat-container-image) that Fedora folk use. We mustn't break their use-case.

OK, this would probably work for the existing use-cases (original_spec_nvr and productmd.compose.id). Hopefully, this won't break anything else.

Why was this changed? This is for different subject type (container-image, not redhat-container-image) that Fedora folk use. We mustn't break their use-case.

This particular change actually changes nothing (see what's set in nvr variable). But I could remove it if you would like (or maybe we could rename the variable, cause its name is actually confusing).

OK, this would probably work for the existing use-cases (original_spec_nvr and productmd.compose.id). Hopefully, this won't break anything else.

This change should be there, because otherwise any message, containing nvr field in data will be considered as redhat-container-image subject type, disregarding its real subject type.

Why was this changed? This is for different subject type (container-image, not redhat-container-image) that Fedora folk use. We mustn't break their use-case.

This particular change actually changes nothing (see what's set in nvr variable). But I could remove it if you would like (or maybe we could rename the variable, cause its name is actually confusing).

Oh, OK. Would be better to either revert it (because it's an unrelated change) or rename the nvr to less confusing item.

1 new commit added

  • Rename the confusing variable in test_consume_new_result_container_image

Why was this changed? This is for different subject type (container-image, not redhat-container-image) that Fedora folk use. We mustn't break their use-case.

This particular change actually changes nothing (see what's set in nvr variable). But I could remove it if you would like (or maybe we could rename the variable, cause its name is actually confusing).

Oh, OK. Would be better to either revert it (because it's an unrelated change) or rename the nvr to less confusing item.

renamed

+1

1 new commit added

  • Suppress pylint warning for test

Pull-Request has been merged by vmaljulin
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.