Signed-off-by: Valerij Maljulin vmaljuli@redhat.com
It's safer just create a formatting dict in these branches:
format_dict = {} if '{pkg_name}' in cur_subject_url ...: ... format_dict.update(rev=rev, pkg_name=pkg_name, pkg_namespace=pkg_namespace) if '{subject_id}' in cur_subject_url: ... format_dict.update(subject_id=subj_id) response = greenwave.resources.retrieve_yaml_remote_rule( cur_subject_url.format(format_dict) )
Just 1 comment, otherwise it looks good.
rebased onto 8c89050803bb81363b9c6cc9ef429dfaac83c25e
Updated
+1
Commit 23e59dd5 fixes this pull-request
Pull-Request has been merged by vmaljulin
Signed-off-by: Valerij Maljulin vmaljuli@redhat.com