LGTM

+1

Where do env* and review-greenwave come from? Seems like they are just stuff left in your work tree rather than anything that would normally be produced by our build processes?

env* is genereated from virtualenv and review-greenwave is generated from fedora-review. Having them in .gitignore would simply prevent me or others commiting those things, :-P

Okay but those paths are just specific to you though, because you made them once. You can put them into your personal ~/.gitignore if you want. The stuff we commit to the project .gitignore should only be project specific build artefacts that are produced by the project's normal build/test processes. Otherwise it will just end up filling with piles of random crap.

Alright, I will remove them.