I assume this setting is important to define, and that it's important that it not be defined as the default value. Thus, I recommend adding another if statement after this block to verify that the secret key is defined and that it is not a default value, raising an Exception otherwise.

I recommend tests for this change. LGTM otherwise.

+1

Yeah, we do have this when the app is created.

https://pagure.io/greenwave/blob/master/f/greenwave/app_factory.py#_39

I recommend tests for this change. LGTM otherwise.

A unit test may not be necessary as we will use OpenShift to run function tests, as if what we have done for WaiverDB. This will be tested when delopying OpenShift with a template like this[1].

https://pagure.io/waiverdb/blob/master/f/openshift/waiverdb-test-template.yaml

I'll go ahead to merge. If you guys think a test is necessary, I'll file a new PR for it.

Is the Flask secret key ever used for anything? Porbably not, since we don't use sessions or any other signed cookies... Anyway no harm in having it.