greenwave

Clone

#545 Fix converting Subject to string and repr
Merged 4 years ago by lholecek. Opened 4 years ago by lholecek.
lholecek/greenwave fix-subject-repr  into  master

file modified
+6 -1 
@@ -129,5 +129,10 @@ 
 

  

      def __str__(self):
 

          return "subject_type {!r}, subject_identifier {!r}".format(
 

-             self.type_, self.item
 

+             self.type, self.item
 

+         )
 

+ 

+     def __repr__(self):
 

+         return "Subject({!r}, {!r})".format(
 

+             self._type, self.item
 

          )

file modified
+3 
@@ -62,6 +62,9 @@ 
 

      def safe_yaml_label(self):
 

          return 'SubjectType {!r}'.format(self.id)
 

  

+     def __repr__(self):
 

+         return '<SubjectType {!r}>'.format(self.id)
 

+ 

  

  class GenericSubjectType:
 

      def __init__(self, id_):

file modified
+10 
@@ -92,3 +92,13 @@ 
 

          'system_architecture': ['x86_64'],
 

      }
 

      assert subject.get_latest_results(results)[1]['outcome'] == 'PASSED'
 

+ 

+ 

+ def test_subject_to_str(app):
 

+     subject = create_subject('koji_build', 'some_nvr')
 

+     assert str(subject) == "subject_type 'koji_build', subject_identifier 'some_nvr'"
 

+ 

+ 

+ def test_subject_to_repr(app):
 

+     subject = create_subject('koji_build', 'some_nvr')
 

+     assert repr(subject) == "Subject(<SubjectType 'koji_build'>, 'some_nvr')"

Signed-off-by: Lukas Holecek hluk@email.cz

@gnaponie @vmaljulin Please review. This doesn't lead to any issues (yet) but it fixes logs.

+1
this _type, type, type_ is confusing D:

Commit b42297d fixes this pull-request

Pull-Request has been merged by lholecek
4 years ago

Pull-Request has been merged by lholecek
4 years ago
Metadata
None
No Tags
Changes Summary 3
+6 -1
file changed
greenwave/subjects/subject.py
+3 -0
file changed
greenwave/subjects/subject_type.py
+10 -0
file changed
greenwave/tests/test_subjects.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.