Signed-off-by: Lukas Holecek hluk@email.cz
The way the on-demand policy loading is implemented is bad. The code needs to be updated if we add a new attribute to existing rule or policy class, or add a new rule -- and there is no code that checks consistency or if the loaded attributes are valid.
1 new commit added
Make on-demand policies loading more generic
2 new commits added
Fix loading RemoteRule attribute in on-demand rules
I've changed to code to be more generic (in the second commit).
could you please rename this var, so there's no trailing underscore
+1 after fixing minor comment above
type is function in Python. Adding underscore suffix is a standard way to avoid using conflicting names (type_ is used on couple of other places in code already).
type
type_
I know that. I mean that you can rename it to something more meaningful and more descriptive like xyz_type
rebased onto 069c5c773e4cf54dac2e359d526ad968a6369c18
type is function in Python. Adding underscore suffix is a standard way to avoid using conflicting names (type_ is used on couple of other places in code already). I know that. I mean that you can rename it to something more meaningful and more descriptive like xyz_type
Renamed to item_type.
item_type
Pull-Request has been merged by lholecek
Signed-off-by: Lukas Holecek hluk@email.cz