#520 Fix default generic subject type attributes
Merged 4 years ago by lholecek. Opened 4 years ago by lholecek.

@@ -15,19 +15,6 @@ 

  )

  

  

- class GenericSubjectType:

-     def __init__(self, id_):

-         self.id = id_

-         self.aliases = []

-         self.is_koji_build = True

-         self.is_nvr = False

-         self.supports_remote_rule = False

-         self.product_version = None

-         self.item_dict = {}

-         self.result_queries = []

-         self.latest_result_unique_keys = []

- 

- 

  class SubjectType(SafeYAMLObject):

      root_yaml_tag = '!SubjectType'

  
@@ -76,6 +63,18 @@ 

          return 'SubjectType {!r}'.format(self.id)

  

  

+ class GenericSubjectType:

+     def __init__(self, id_):

+         self._set_default_attributes()

+         self.id = id_

+         self.is_koji_build = True

+         self.is_nvr = False

+ 

+     def _set_default_attributes(self):

+         for name, attr in SubjectType.safe_yaml_attributes.items():

+             self.__setattr__(name, attr.default_value)

+ 

+ 

  def load_subject_types(subject_types_dir):

      """

      Load Greenwave subject types from the given directory.

Makes sure that all attributes for generic subject type are set.

Signed-off-by: Lukas Holecek hluk@email.cz

(I noticed that there was no GenericSubjectType.ignore_missing_policy after I broke some functionality and tests started to require it.)

rebased onto 9cd69b5

4 years ago

Commit b6269ce fixes this pull-request

Pull-Request has been merged by lholecek

4 years ago

Pull-Request has been merged by lholecek

4 years ago
Metadata