DO NOT MERGE YET!

Can you add a test with this scenario:
you have 2 rules in a policy in the global conf: PassingTestCaseRule and RemoteRule. You can create a result that would make the PassingTestCaseRule pass. Then you can mock the failure (NoSourceException) and check if the "PassingTestCaseRule" was processed (satisfied) or ignored.

This test would check if the behaviour is the expected one.

No need to log the stacktrace, the error message would be enough.

Comments were addressed

Can you rather mock just the koji data? (I.e. mock xmlrpc.client.ServerProxy.getBuild().)

@lholecek Done

I think you can do just koji_server_instance.getBuild.return_value = {'source': None} for clarity.

+1

Can you continue the test with the creation of a result and then check if the decision is satisfied?
This would happen only when "two_rules" is True.

PS. note that this behaviour is not strictly related to the "on-demand" feature, but applies to all cases where the RemoteRule is applicable. So it's easier you can test it also with the "normal" behaviour.

+1

You can avoid of using "nsvc" here, you can use always "nvr" and avoid declaring "nsvc" above.
And then in:
decision = policy.check('fedora-29', nsvc, results)
You would use "nvr" too and instead of "fedora-29" you can use "fedora-30".

I'm actually surprised that it succeeds.. It's a bit strange because you don't have a policy for fedora-29...

Thank you for applying the changes! It looks good.
+1