PR#498: pylint-3 fix - greenwave

greenwave

#498 pylint-3 fix

Merged 4 years ago by gnaponie. Opened 4 years ago by vmaljulin.

vmaljulin/greenwave small_improvements into master

pylint-3 fix

Valerij Maljulin • 4 years ago

32f4807

greenwave/request_session.py

file modified

+2 -2

		`@@ -27,10 +27,10 @@`
		`req_url = kwargs.get('url', args[1])`
		`try:`
		`return super().request(args, *kwargs)`
		`- except (ConnectionError, ProxyError, SSLError) as e:`
		`- ret_val = ErrorResponse(502, str(e), req_url)`
		`except (ConnectTimeout, RetryError) as e:`
		`ret_val = ErrorResponse(504, str(e), req_url)`
		`+ except (ConnectionError, ProxyError, SSLError) as e:`
		`+ ret_val = ErrorResponse(502, str(e), req_url)`
		`return ret_val`

vmaljulin commented 4 years ago

Signed-off-by: Valerij Maljulin vmaljuli@redhat.com

gnaponie commented 4 years ago

Trying to run it, it still gives me this error:
greenwave/request_session.py:26:4: W0221: Parameters differ from overridden 'request' method (arguments-differ)
It's just a warning so we should get the code rated 10/10. But it creates noise. Can we delete it or either ignore it?

lholecek commented 4 years ago

Trying to run it, it still gives me this error:
greenwave/request_session.py:26:4: W0221: Parameters differ from overridden 'request' method (arguments-differ)
It's just a warning so we should get the code rated 10/10. But it creates noise. Can we delete it or either ignore it?

Let's ignore the warning locally: https://pagure.io/greenwave/pull-request/499

lholecek commented 4 years ago