PR#497: Change error from 502 to 404 when Koji build not found - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

greenwave

#497 Change error from 502 to 404 when Koji build not found

Merged Oct 15, 2019 by vmaljulin. Opened Oct 14, 2019 by vmaljulin.

vmaljulin/greenwave FACTORY-4255 into master

Download 497.patch

vmaljulin commented Oct 14, 2019

This fixes #415

Signed-off-by: Valerij Maljulin vmaljuli@redhat.com

rebased onto 36b52319176db24e981aecaf7bb4d4522f80ad88

Oct 14, 2019

lholecek commented Oct 14, 2019

This could potentially break someone's code.

Can you add documentation for the status code? Seems that still only the 200 and 400 are in docs.

lucarval commented Oct 14, 2019

This could potentially break someone's code.
Can you add documentation for the status code? Seems that still only the 200 and 400 are in docs.

+1 let's update the docs to avoid confusion.

gnaponie commented Oct 15, 2019

Agreed on the doc, otherwise +1
And as a reminder: we need to release a major version since it's not backward compatible.

rebased onto d2e3f234fa05807962d36789ead4704999b24e2c

Oct 15, 2019

gnaponie commented Oct 15, 2019

Looks good to me

lholecek commented Oct 15, 2019

+1

Pull-Request has been merged by vmaljulin

Oct 15, 2019

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.