FYI @bgoncalv @dcantrel

Agreed and the patch looks fine to me.

But isn't ERROR state a final state? It seems to be in a different category than the transient states RUNNING and QUEUED.

Could you clarify the importance of this change?

Yes, it is a final state. It is normal priority. Requires additional changes in Greenwave: https://pagure.io/greenwave/issue/488 and resultsdb updater (both upstream and downstream)

This just changes development docker-compose environment.

I think you need to change it in fedora infra repo.

Internally, ResultsDB should already accept the ERROR status, but ResultsDB-Updater stores ERROR as FAILED anyway.

@mvadkert, I'm afraid @lholecek is right, that's just for the development docker-compose environment.
Lukas, Miro is referring to the internal one AFAIK. But... do you remember where is that defined? Couldn't find it in the ansible playbook repo.

But... do you remember where is that defined? Couldn't find it in the ansible playbook repo.

ADDITIONAL_RESULT_OUTCOMES is defined in the role in our internal repo (ansible-roles/resultsdb).

Ok, I guess I should add the change also there then :)

@lholecek the repos have changed .. .we are not able to find ansible-roles/resultsdb anymore ...

@lholecek as Miro said... I checked resultsdb-updater-playbooks, resultsdb-playbooks and greenwave-playbook. But there's no "ADDITIONAL_RESULT_OUTCOMES" or ("additional_result_outcomes"). Can you point us to it?
/me cannot find it...

I've replied via mail with the links to internal repo.

@mvadkert You've already fixed this for our internal instance.

It's OK to modify the configuration here but it won't have any effect for our instances (and I can see the value overridden in fedora-infra ansible repo also).

Ack. I think we are all set here :)

+1 to merge this even if this won't affect existing instances, it's safer to have the list of commonly used test result outcomes mentioned on multiple places.