#473 Add required flag to RemoteRule
Merged by lucarval. Opened by lholecek.
lholecek/greenwave remote-rule-requiered-flag  into  master

Download 473.patch

Can we add that by default is just skipped? Like not considered at all.

I think it should be "the following decision".

Is it correct to put this as summary? Shouldn't that be something different? Like "Expected 1 additional policy and not found" or something...

That could make creating the summary unnecessarily complicated.

That could make creating the summary unnecessarily complicated.

But do you think it is correct to say that one test is failing? Shouldn't be more correct at this point to say it is missing?

rebased onto b6a01ef224af02be76dd7dbd9f56c9f588c5ba8d

Anyhow.. that's my only concern. The PR looks good.
I didn't check myself the tests and the syntax, but I trust you on that :D

But do you think it is correct to say that one test is failing? Shouldn't be more correct at this point to say it is missing?

Hmmm, I think the "test" is rather "failed" than "missing".

Ok, I guess that's just my preference. Feel free to leave it like that then :)

To summarize: +1 :)

@lucarval Can you please review too?

Does this mean you can't waive the RemotePolicy check when it's required?

Consider using yaml.load to convert string to boolean.

Does this mean you can't waive the RemotePolicy check when it's required?

It works same as waiving invalid-gating-yaml, you just use missing-gating-yaml test case name instead.

rebased onto 7d0d5b668041d771975673e8e7d153e19381edaa

Consider using yaml.load to convert string to boolean.

Thanks, that's the solution I was looking for.

Strangely, y and n are evaluated as strings even though yaml.org mentions it should be bool. Maybe it's just safety thing with yaml module.

:thumbsup:

Commit 8e58264c fixes this pull-request

Pull-Request has been merged by lucarval

Pull-Request has been merged by lucarval

Metadata