#461 Refactor consumers
Merged by yashn. Opened by lholecek.
lholecek/greenwave refactor-consumers  into  master

Download 461.patch

Move common consumer code to Consumer base class.

Signed-off-by: Lukas Holecek hluk@email.cz

rebased onto 0f787c96af3283f752e13f3f3a4f1ac967523375

rebased onto 590f4563f129a8c9610e46a477c99f83900044b8

This is lost. Intentional?

Other than my previous comment, this seems reasonable.

This is lost. Intentional?

Yes, the cache has been removed for resultsdb some time ago and this variable was left unused.

:thumbsup:

Commit b3942ce7 fixes this pull-request

Pull-Request has been merged by yashn

Pull-Request has been merged by yashn

Sorry I didn't review this... I was too slow. It was in my todo list :D

Sorry I didn't review this... I was too slow. It was in my todo list :D

Sorry I was unaware that this was waiting for another review. I merged it because it had a +1 from Luiz.

Eheh @yashn, no prob! It's my bad I was slow, not your bad that you merged it :D
Lui's +1 is enough. I was just planning to have a look before merging it myself :)

Metadata