greenwave

#45 change the subject of a decision to a list of dicts
Merged by mjia. Opened by mjia.
mjia/greenwave issue34  into  master

Download 45.patch

For the CentOS CI test results there might be no 'item' key at all in ResultsDB, so we have to modify the subject list field in the POST /decision API to accept
a list of dicts rather than a list of 'item' key , where each dict contains one or more key-value pairs of 'data' key in ResultsDB. Greenwave will then look
up results by passing these key-value pairs directly to the ResultsDB query.

:+1: from me in a general sense.

Does this need documentation updates too?

/cc @bowlofeggs did you see this?

@ralph , do you mean the focus doc?

I think rbean is just talking about the Sphinx docs... Looks like you have updated the arg descriptions, but there are some request/response examples which will need updating too, right?

Hmm, I think I've updated these examples already.

I think rbean is just talking about the Sphinx docs...

Yeah, that's correct. Just the sphinx docs.

I think we can consider the focus docs basically frozen unless something monumental changes.

I see now that the sphinx docs are just autodocs from the doc strings. My bad!

So, again, :+1:.

Pull-Request has been merged by mjia

Looks good! Thanks for the heads up @ralph.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.