Do the functional tests work for you?
They don't for me :(

https://paste.fedoraproject.org/paste/edNO9UvtY~xTTPSjPw6Pdw

@gnaponie Thanks. Checking the number of metrics appears to be different for different environments, depending mainly on prometheus_client library version. I changed it to min_num_of_metrics which should work now. For future, I need to think of a better, yet simple way of testing the metrics.

Hello fivaldi. Sorry for the late reply.
It seems still not to work for me :(
Could we find a better way to be sure this will always work?
These are my errors:
https://paste.fedoraproject.org/paste/avtKU~8NX2bK3t61mM2tqA

@gnaponie Seems like you're not testing against the latest revision in the branch: 5eefffa

Otherwise it would pass for you, because there's the >= (greater than or equals) in the test(s).

Yeah, you're right. Sorry about that. They work now, thanks. I'll make another review now.

What's the reason of adding another blueprint? Couldn't we just use the "api" one?
Is it just for keeping the 2 things separated?

What does "rx" stand for?

Same question for "tx" :)

Beside those comments (I'm just curios about them), the PR looks fine!

@gnaponie it means "received", but it may be worth renaming it

@gnaponie it means "transmitted"

The reason is to avoid "grafting" of the monitor module in different ways per each F2.0 project, as there are slight differences in the Flask API implementations. The blueprint way appears to be universal and simple. If the monitor module extends with other functionality, it's gonna work on most of F2.0 projects out of box.

Exactly, "rx" means receive(d), "tx" means transmit(ted). They're common in communication terminology, transferring of data, packets, frames etc. From my point of view, these two very important abbreviations should not be forgotten. :-)

It looks good. I think we can merge it!

Commit 75086927 fixes this pull-request

@gnaponie Thank you.