greenwave

#397 Fix running functional tests in virtualenv
Merged by gnaponie. Opened by lholecek.
lholecek/greenwave fix-unicorns-in-venv  into  master

Download 397.patch

Fixes running system installation of Gunicorn from pytest in virtualenv.

Invocation example:

python3 -m venv --system-site-packages .venv
source .venv/bin/activate
pip install -r dev-requirements.txt
pip install -r ../waiverdb/requirements.txt
pip install -r ../resultsdb/requirements.txt
python -m pytest -x functional-tests

Signed-off-by: Lukas Holecek hluk@email.cz

Why is that needed?
Doesn't that work for you without it?

It doesn't work without this patch because gunicorn (system-installed) worker for waiverdb (functional-tests) is failing with fedora_messaging module not found.

Oh! I had this issue too. I thought it was something else.
cc. @yashn might be the thing we were discussing before
Let me check if that is the same for me.
Edited by gnaponie

...forget about my comment, please.
The functional-tests run correctly for me, but I don't use a virtualenv.
@lholecek this change is ok by me. But it might be worth mentioning in the doc that if you want to run the tests in the virtualenv you might do as you proposed in you comment.

...forget about my comment, please.

No problem, apparently, from your pull request, I don't have any problem forgetting what was discussed before. :)

But it might be worth mentioning in the doc that if you want to run the tests in the virtualenv you might do as you proposed in you comment.

Sure, I could update the dev docs in other pull request.

Eheh. Great! Thanks.

rebased onto 9b2478269f1c08adbf23f403ca39a9cc019031a4

Pull-Request has been merged by gnaponie
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.