#389 Add the option to use "git archive" to retrieve a gating.yaml file from dist-git
Merged by gnaponie. Opened by mprahl.
dist-git-timing-issues  into  master

Download 389.patch

This is to address when the dist-git deployment doesn't have a UI that updates in real-time, such as cgit.

rebased onto 591f6e944d4f44d1a073df9c5f0bbffbac38373f

mmm shouldn't we add this also in the Jenkinsfile and the Vagrant file?

mmm why this white-space?

Anyhow... it looks fine +1

It's already present in the Vagrantfile and it shouldn't be needed in Jenkins because the functional tests don't use it and the unit tests have the use of git archive mocked. Do you think it's actually needed in Jenkins?

It's up to you, but I usually format my imports like so:

# stdlib imports
# third-party imports
# local imports

What style do you prefer?

Yeah I guess it should be fine.

I guess we don't have a real standard in Greenwave... but usually it's the same as yours, but no blank lines :) -- that's not even always true... I guess we could start with some kind of standard.
Let's leave it like that here and maybe we can adopt that for every other file in the future.

Thank you @gnaponie. Is this good to merge now?

rebased onto c847939ef0c649e7323c3374bda16a4b9caac005

Yeah let's merge it!

Pull-Request has been merged by gnaponie

Metadata