Were you able to run successfully the functional tests with this configuration?

@gnaponie no, because the functional tests run their own instances of ResultsDB, WaiverDB, and expect Postgres to be running. In my opinion, it'd be nicer to just use containers like Estuary API does, but I just started looking at Greenwave and don't want to change the workflow if it's been working for you all.

I fixed some typos and this is now ready for review.

+1

I forgot there is docker-compose.yml. Would be nice if the greenwave project directory is mounted read-only and test can be run in the container as well.

+1
I forgot there is docker-compose.yml. Would be nice if the greenwave project directory is mounted read-only and test can be run in the container as well.

Yes, that would be nice. I'll talk with @gnaponie about this.

Yeah, I like the idea of running everything on a container, but yeah, we should make it work for the functional-tests that need an instance of WaiverDB/ResultsDB as you said...

The PR looks fine to me! I would maybe just write that this is just for developing purposes, and you cannot run the functional tests, so don't try to do that. But it's not mandatory... tests are not mentioned at all, so maybe it's already clear without explicitly tell that.

@gnaponie I added instructions on how to run the unit tests. Thanks for the review.

+1

Commit c02ed8ec fixes this pull-request