Looks like in gating.yaml the subject_type is still optional but not set to koji_build by default. Looks like breaking change.

Can we keep it that way and deduce the type from namespace in dist-git URL?

Looks like in gating.yaml the subject_type is still optional but not set to koji_build by default. Looks like breaking change.

Oh no! Did I missing something in this PR? https://pagure.io/greenwave/pull-request/350#request_diff

Can we keep it that way and deduce the type from namespace in dist-git URL?

I'd like to minimize the amount of guessing greenwave does. IMO it's much more straightforward to have such tings explicitly defined.

The default is still koji_build, it's a SafeYAMLChoice and the "default_value" of that is the first choice (the element with index 0 in the list of choices). I'm pretty sure about that, the last test I wrote for it fails if you don't specify the subject_type in the gating.yaml, because it always puts koji_build (the default) - it was failing because the matching policy was a redhat-module.

I would also avoid to guess it, it's not a big effort for the user to just put "koji_build" (or whatever it is) in the gating.yaml. And the change is not breaking anything because the default is still "koji_build", that was the only possible one until now.

Understood. Should the docs mention then that the default value is koji_build?

Rebased adding the default value.

+1

:+1:

Commit 36c19e60 fixes this pull-request