greenwave

#337 Capitalize the first letter of the summary for a passing gating decision
Merged by gnaponie. Opened by mprahl.
capitalize-summary-first-letter  into  master

Download 337.patch

I currently display the summary of a gating decision in a tooltip in Estuary. Since the "a" isn't capitalized in "all required tests passed", I have to use JavaScript to do so. It'd be nice if I didn't have to do that.

:thumbsup: I don't see a problem with this.

I'm not sure if someone is checking that outside of Greenwave...
@mvadkert @pingou @bowlofeggs what about you? Could you review this PR?

sounds good :)

:thumbsup:

There is also 'no tests are required' but I found a check for it in Bodhi.

@lholecek but that's not related to this PR. Are you ok with merging this one?

@lholecek but that's not related to this PR. Are you ok with merging this one?

+1 Yes, OK for me.

Commit efabbf10 fixes this pull-request

Pull-Request has been merged by gnaponie

Pull-Request has been merged by gnaponie

Bodhi does not use this string, so I don't think this will be a problem.

Great! Thanks for the feedback.
So I'll update Greenwave in Fedora soon.
I'm a bit worried about doing that before Christmas :) let's see.

On Thu, 2018-12-20 at 14:56 +0000, Giulia Naponiello wrote:

I'm a bit worried about doing that before Christmas :) let's see.

I highly recommend waiting until after the shutdown. There are very few
people to handle problems if something goes wrong.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.