#324 Check RemoteRule configuration at start
Merged by gnaponie. Opened by lholecek.
lholecek/greenwave omit-conf-test-in-decision  into  master

Download 324.patch

rebased onto 0a65a29e0350281905349e892fcd11e064bf205c

Out of curiosity, why move these tests out of test_utils.py when they're only testing entities from utils.py?

@lucarval Oops, I messed up. I copied test_utils.py to test_app_factory.py but started changing the first one.

Thanks for noticing, I should have reviewed the patch before submitting. Fixing it now.

rebased onto 84d071e777623fd3a8f6e594c68d55025767657b

I don't remember why we've put that in the API, there was a good reason... I guess because we didn't want to block the user if s(he) doesn't actually start using it. But I guess it is fine if we check if there's a RemoteRule in the conf and then if there's not we raise an error if the conf is not configured properly. It makes sense. I hope I'm not forgetting something.

So +1 to me

rebased onto 064c0c75979ef0cdab85e8d98d290d47af6f77f4

Pull-Request has been merged by gnaponie

Metadata