#316 Adjust naming scheme for one prometheus metric.
Merged 5 years ago by lholecek. Opened 5 years ago by ralph.

file modified
+6 -2
@@ -8,7 +8,11 @@ 

  from greenwave.resources import ResultsRetriever, retrieve_waivers, retrieve_builds_in_update

  from greenwave.safe_yaml import SafeYAMLError

  from greenwave.utils import insert_headers, jsonp

- from greenwave.monitoring import registry, decision_exception_counter, decision_latency

+ from greenwave.monitoring import (

+     registry,

+     decision_exception_counter,

+     decision_request_duration_seconds,

+ )

  

  

  api = (Blueprint('api_v1', __name__))
@@ -165,7 +169,7 @@ 

  

  @api.route('/decision', methods=['POST'])

  @decision_exception_counter.count_exceptions()

- @decision_latency.time()

+ @decision_request_duration_seconds.time()

  @jsonp

  def make_decision():

      """

file modified
+3 -1
@@ -17,7 +17,9 @@ 

  decision_exception_counter = Counter('total_decision_exceptions', ('All exceptions occurred in '

                                                                     'Greenwave "decision" API'),

                                       registry=registry)

- decision_latency = Histogram('decision_latency', 'Decision latency', registry=registry)

+ decision_request_duration_seconds = Histogram('decision_request_duration_seconds',

+                                               'Decision latency',

+                                               registry=registry)

  publish_decision_exceptions_waiver_counter = Counter('publish_decision_exceptions_new_waiver',

                                                       ('All exceptions occurred in publishing a '

                                                        'message after a new waiver'),

I ran across some best practices guidelines from upstream:
https://prometheus.io/docs/practices/naming/

Commit ef5a27b fixes this pull-request

Pull-Request has been merged by lholecek

5 years ago

Pull-Request has been merged by lholecek

5 years ago