greenwave

#302 Assume result failed if outcome is FAILED or NEEDS_INSPECTION
Closed by ralph. Opened by lholecek.
lholecek/greenwave result-outcomes  into  master

Download 302.patch

There are new test result outcomes (QUEUED, RUNNING) which should be
considered as missing results.

:( uff... it was mine and it was almost done :( I'll just submit my tests when this one gets merged.
Reviewing now this one...

I would put if result['outcome' in ('QUEUED', 'RUNNING'), because we also have "NOT_APPLICABLE" as additional result outcomes and we don't know what we will have in the future.

Would this early return short-circuit the waiver checking which happens in the next stanza?

@ralph That's right, my bad. I'm dropping this PR anyway in favor of PR#303. I don't want to steal Giulia's fame. :)

@gnaponie Is "NOT_APPLICABLE" mentioned somewhere?

@lholecek only in the internal instance afaik. You can check the internal task FACTORY-2035 for more information.

Closing in favor of #303.

Pull-Request has been closed by ralph
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.