greenwave

#296 Try to get product version for decision change
Merged by lholecek. Opened by lholecek.
lholecek/greenwave publish-correct-product-version  into  master

Download 296.patch

Omits publishing incorrect policies in decision change messages when
it's possible to get the product version from the new test result
subject.

Fixes #198

+1
But what happens if it cannot guess the product version? Will it just publish the wrong one as before? I guess add some warning log is useless...

It will just use the product_version from policies which should still work unless it's the glob pattern.

I can print a warning or error if it cannot get the real product version and the one in policy contains *, ? or [ (it won't be able to retrieve old policy anyway). Is that OK?

Rebased.

rebased onto 90836e10f845edfe34bb3335e3901f947859594d

:+1: here too, but... are we stuck on Jenkins again?

👍 here too, but... are we stuck on Jenkins again?

I'm OK with ignoring failed result where it throws the exception after End of Pipeline message (and there is no other error).

I'm OK with ignoring failed result where it throws the exception after End of Pipeline message (and there is no other error).

I agree

Commit 64953532 fixes this pull-request

Pull-Request has been merged by lholecek

Pull-Request has been merged by lholecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.