greenwave

#266 Greenwave should consider that aliases exist
Merged by gnaponie. Opened by gnaponie.
gnaponie/greenwave fix-alias  into  master

Download 266.patch

Greenwave was checking if the url.netloc of the build['source']
found in the koji/brew build is in the configured DIST_GIT_BASE_URL.
The problem is that the dist-git server can have an alias, and
this check is raising an error blocking the decision.
Removing the check for now... maybe in the future we can find a
smarter way to check that.

+1

Pull-Request has been merged by gnaponie

Would it be worth filing an issue to re-introduce this check but in a way that works with CNAMEs? Otherwise I feel like everyone will forget :-)

Or maybe we don't need the check at all... tbh I cannot remember why it was even needed...

@dcallagh yes, actually I was wondering: do we need that? I don't think so. I guess it was just an additional check, just to be sure. What do you think? If someone think it is necessary I'll file an issue.

Yeah it seems unnecessary, since Greenwave is already going to look up the gating.yaml in the proper configured dist-git URL. The worst that can happen is the git revision is from somewhere else and thus does not exist. So it seems safe to just drop this check.

I agree. Thanks for your opinion on that
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.