#245 tests: Wait for services set up using *_TEST_URL variables
Closed by lholecek. Opened by lholecek.
lholecek/greenwave tests-wait-for-services  into  master

Download 245.patch

Related to PR#244.

I also had to move some function out of utils.py to avoid circular imports.

Hmm I don't get it... Why do we need all this in Python?

I think it makes more sense to just rely on Openshift to tell us when the services and up and ready. We already do that (just not correctly).

Well, if Jenkins can really ensure that the pods are ready (serving on given port) before running tests then, yeah, this is not needed.

I'll probably do another PR so that it's possible to import utils.py in tests (the imports sometimes doesn't make sense - lower-level submodule import higher-level one).

Pull-Request has been closed by lholecek

Metadata