#23 add a policy for Fedora
Merged by mjia. Opened by mjia.
mjia/greenwave factory-904  into  master

Download 23.patch

I guess Fedora PDC has no product versions because they haven't been needed for anything yet?

I think fedora-26 is a reasonable identifier, it lines up with rhel-7 and similar ones we have internally. We can probably ask Fedora infra (or Ralph) to populate some product versions in Fedora PDC for us...

I guess we will need to get Fedora QA's input as to which Taskotron tests should block a Bodhi update... but those three "release critical" ones certainly sound like a good start.

Yeah, as mentioned in Jira, I'll make a demo and ask these guys to give me feedback.

Are you planning to seek their feedback, then update this PR?

You could also do it the other way round if you want -- merge this first (after rebasing on the YAML policies patch) and then do a demo and update the policy based on the outcome of the discussion. But in that case we would want to be clear that it's not a policy for Fedora, but a proposed policy for Fedora.

Also you have "TODO add test" in the PR description, that sounds like a good idea to me :-)

That's a good idea, I'll add tests in.

rebased

Rebased to add the tests. This rebase is based on the YAML policies patch and I've moved the policies from functional-tests to conf in oder to be able to easily test this patch.

rebased

Rebased again to remove the part which has been done in the YAML policies patch from commit
5a9c9714

rebased

Pull-Request has been merged by mjia

Metadata