That's very poor coverage. With functional-tests it makes ~80%.

Oh no! Why remove Python 3?

Could we have Jenkins use RPM packaged dependencies instead?

Also... isn't the test suite already up and running in Jenkins, using RPM packaged dependencies? 🤔

Could we have Jenkins use RPM packaged dependencies instead?

We could, all the ones in dev-requirements are in the fedora repos... If that's what we prefer I could definitely set it up for that.

Also... isn't the test suite already up and running in Jenkins, using RPM packaged dependencies?

Right now the tests are using RPMs only. The Jenkins job is not currently running the functional tests, however.

As an outsider/new guy, the current dev-requirements do not work due to the renaming of the resultsdb_api package, and I'm not sure why it would need to exist without these changes? Running through the dev guide is an exercise in resolving import errors. This isn't a requirement toward our Jenkins goals, but its a nice to have, given that many other python projects can work entirely inside a virutalenv.

It didn't work! :D

So far, waiverdb has gone mostly py3 only, but greenwave is still stuck on py2. Getting it to py3-only asap is a worthy goal.

Good to know.

@jmolet did you miss this step in the dev guide?

sudo dnf builddep greenwave.spec

That should install all dependencies, you shouldn't have to chase any more.

That is my preferred strategy (rather than doing pip/virtualenv stuff) because it means you get exactly the same packages as what we run in production. To my mind, it is crucial that we test the same thing we are deploying.

As a random example: in years past if you pip installed requests, it would lack the SSL cert handling patches which were in Fedora, so you effectively got completely different SSL cert checking behaviour compared to the RPM packaged version of requests.

That aside, I am :+1: on this patch since it brings the pip/setuptools/tox stuff in line with what we actually have.

Thanks all!