greenwave

#1 Add some boilerplate for the project
Merged by jcline. Opened by jcline.
jcline/greenwave skeleton  into  master

Download 1.patch

This just adds a bunch of boilerplate configuration and skeletons to the project:

  • A setup.py

  • A Python package with some basic documentation

  • A sphinx project with some initial documentation about contribution/style/etc

  • A test coverage configuration

  • A tox.ini file

LGTM. :thumbsup:

:+1: thanks @jcline

:100:

@jcline, you should have rights to merge.

Pull-Request has been merged by jcline

Although I like how ambitious this is, should we consider lowering this amount to something like 95%?

We can leave it at 100 now, but it's something to consider in the future.

This is, of course, something maintainers all have to agree to, but coverage has great exclusion support, so you can exclude individual lines, conditional branches, functions, classes, and whole source files from the coverage report. If there's code it doesn't make sense to test, it's easy to exclude it.

I'm certainly not advocating tests for literally every line of code even when it makes no sense. In my opinion, everything should either be tested or be excluded and justified and this is enforced with the 100% coverage requirement.

Okay, I'm good with that. Thank you for the explanation.
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.