#92 the waiverdb consumer doesn't work properly if the results have extra keys beyond `type` and `item`
Closed 6 years ago Opened 6 years ago by mjia.

For the results that have extra keys beyond type and item, the waiverdb consumer would not be able to handle them correctly. The issue was initially reported in #PR89 which has been merged, so I copied it to here for further discussion.

Excerpts from Dan's comment:

However, there are many results which have extra keys beyond just type and item. Most have scenario now. And rpmdeplint results have arch because there is a separate result for each arch tested. And OpenQA has arch, firmware, and some others.

So the waiverdb consumer won't handle those correctly I think.

Come to think of it, we also haven't considered the problem of different results-per-arch and the extra scenarios that OpenQA does (BIOS vs. EFI). This is basically the "scenarios" problem that Bodhi already had to try and deal with, as discussed in this thread:

https://lists.fedoraproject.org/archives/list/resultsdb-users@lists.fedoraproject.org/thread/DJSIOLA3YEH6HNSJEXVPLIZT5TW4CDED/


I've come to see that this problem applies not just to the waiverdb consumer, but to the resultsdb consumer as well (perhaps mostly just the resultsdb consumer).

We've talked about giving Greenwave the ability to remember what queries it has been asked, and using those to construct its announcements. We may well need to get there.

In lieu of that, I'm proposing #109.

Metadata Update from @ralph:
- Issue status updated to: Closed (was: Open)

6 years ago

#109 did not really fix anything here. See https://pagure.io/greenwave/issue/122 for lots and lots more detail on this.

Login to comment on this ticket.

Metadata