greenwave

#668 RemoteRule policy not listed as 'applicable' if package contains no rules for the context
Closed: Fixed by lholecek. Opened by adamwill.

Closed: Fixed
Reopen Issue

This is the greenwave response for https://bodhi.fedoraproject.org/updates/FEDORA-2023-fb366d5ed5 right at this moment:

{"applicable_policies":["kojibuild_bodhipush_no_requirements","bodhiupdate_bodhipush_no_requirements","bodhiupdate_bodhipush_openqa_netinst","bodhiupdate_bodhipush_openqa_workstation_live","bodhiupdate_bodhipush_openqa_kde"],"policies_satisfied":true,"results":[{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-silverblue-dvd_ostree-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41456097","id":41456097,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081569","submit_time":"2023-08-18T18:45:54.792977","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.rpmostree_overlay","name":"update.rpmostree_overlay","ref_url":"https://openqa.fedoraproject.org/tests/2082232"}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-silverblue-dvd_ostree-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41456043","id":41456043,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081568","submit_time":"2023-08-18T18:39:16.195434","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.rpmostree_rebase","name":"update.rpmostree_rebase","ref_url":"https://openqa.fedoraproject.org/tests/2082132"}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-silverblue-dvd_ostree-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41456003","id":41456003,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081567","submit_time":"2023-08-18T18:32:50.362146","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_ostree","name":"update.install_default_update_ostree","ref_url":"https://openqa.fedoraproject.org/tests/2082131"}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-silverblue-dvd_ostree-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455427","id":41455427,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081566","submit_time":"2023-08-18T18:01:01.033348","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.ostree_build","name":"update.ostree_build","ref_url":"https://openqa.fedoraproject.org/tests/2082130"}},{"data":{"arch":["x86_64"],"firmware":["uefi"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-kde-live-iso.x86_64.uefi"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455342","id":41455342,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081565","submit_time":"2023-08-18T17:52:58.195915","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_live","name":"update.install_default_update_live","ref_url":""}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-kde-live-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455338","id":41455338,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081564","submit_time":"2023-08-18T17:50:46.467771","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_live","name":"update.install_default_update_live","ref_url":""}},{"data":{"arch":["x86_64"],"firmware":["uefi"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-workstation-live-iso.x86_64.uefi"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455337","id":41455337,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081558","submit_time":"2023-08-18T17:48:06.389459","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_live","name":"update.install_default_update_live","ref_url":""}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-workstation-live-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455336","id":41455336,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081557","submit_time":"2023-08-18T17:48:02.467877","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_live","name":"update.install_default_update_live","ref_url":""}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-kde-live-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455332","id":41455332,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081563","submit_time":"2023-08-18T17:33:00.344737","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.live_build","name":"update.live_build","ref_url":"https://openqa.fedoraproject.org/tests/2082169"}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-workstation-live-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455331","id":41455331,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081556","submit_time":"2023-08-18T17:32:37.165239","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.live_build","name":"update.live_build","ref_url":"https://openqa.fedoraproject.org/tests/2082169"}},{"data":{"arch":["x86_64"],"firmware":["uefi"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-everything-boot-iso.x86_64.uefi"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455310","id":41455310,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081562","submit_time":"2023-08-18T17:14:06.983179","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_netinst","name":"update.install_default_update_netinst","ref_url":"https://openqa.fedoraproject.org/tests/2082107"}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-everything-boot-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455309","id":41455309,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081561","submit_time":"2023-08-18T17:14:02.603937","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.install_default_update_netinst","name":"update.install_default_update_netinst","ref_url":"https://openqa.fedoraproject.org/tests/2082107"}},{"data":{"arch":["x86_64"],"firmware":["bios"],"item":["FEDORA-2023-fb366d5ed5"],"meta.conventions":["result fedora.bodhi"],"scenario":["fedora.updates-everything-boot-iso.x86_64.64bit"],"source":["openqa"],"type":["bodhi_update"]},"groups":["0f3309ea-6d4c-59b2-b422-d73e9b8511f3","00261218-45e6-5845-a774-f84cf214da9a","3057147b-a57d-5a5a-8907-b4da3e5e1fad"],"href":"https://resultsdb.fedoraproject.org/api/v2.0/results/41455293","id":41455293,"note":"","outcome":"PASSED","ref_url":"https://openqa.fedoraproject.org/tests/2081560","submit_time":"2023-08-18T16:57:47.299176","testcase":{"href":"https://resultsdb.fedoraproject.org/api/v2.0/testcases/update.installer_build","name":"update.installer_build","ref_url":"https://openqa.fedoraproject.org/tests/2082105"}}],"satisfied_requirements":[{"result_id":41455309,"scenario":"fedora.updates-everything-boot-iso.x86_64.64bit","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.install_default_update_netinst","type":"test-result-passed"},{"result_id":41455310,"scenario":"fedora.updates-everything-boot-iso.x86_64.uefi","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.install_default_update_netinst","type":"test-result-passed"},{"result_id":41455293,"scenario":"fedora.updates-everything-boot-iso.x86_64.64bit","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.installer_build","type":"test-result-passed"},{"result_id":41455336,"scenario":"fedora.updates-workstation-live-iso.x86_64.64bit","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.install_default_update_live","type":"test-result-passed"},{"result_id":41455337,"scenario":"fedora.updates-workstation-live-iso.x86_64.uefi","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.install_default_update_live","type":"test-result-passed"},{"result_id":41455331,"scenario":"fedora.updates-workstation-live-iso.x86_64.64bit","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.live_build","type":"test-result-passed"},{"result_id":41455338,"scenario":"fedora.updates-kde-live-iso.x86_64.64bit","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.install_default_update_live","type":"test-result-passed"},{"result_id":41455342,"scenario":"fedora.updates-kde-live-iso.x86_64.uefi","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.install_default_update_live","type":"test-result-passed"},{"result_id":41455332,"scenario":"fedora.updates-kde-live-iso.x86_64.64bit","source":null,"subject_identifier":"FEDORA-2023-fb366d5ed5","subject_type":"bodhi_update","system_architecture":null,"system_variant":null,"testcase":"update.live_build","type":"test-result-passed"}],"summary":"All required tests passed","unsatisfied_requirements":[],"waivers":[]}

This was the request:

{"product_version":"fedora-38","decision_context":["bodhi_update_push_testing_critical-path-compose_critpath","bodhi_update_push_testing_critical-path-build_critpath","bodhi_update_push_testing"],"subject":[{"item":"binutils-2.39-15.fc38","type":"koji_build"},{"item":"FEDORA-2023-fb366d5ed5","type":"bodhi_update"}],"verbose":true}

Key point: the applicable policies list is ["kojibuild_bodhipush_no_requirements","bodhiupdate_bodhipush_no_requirements","bodhiupdate_bodhipush_openqa_netinst","bodhiupdate_bodhipush_openqa_workstation_live","bodhiupdate_bodhipush_openqa_kde"]. It does not include "kojibuild_bodhipush_remoterule", even though AFAICS it really should. That policy is listed in fedora.yaml for the bodhi_update_push_testing context.

The response may be different when you read this report, because it seems like it changes when the update is pushed to updates-testing. Right now, the update is pending push to -testing. It seems like when it is actually pushed to -testing, the response changes, and now the remoterule policy is properly applied (I've been through this cycle twice with this update now). But I can't see why.

I intend to look into this next week, just filing the issue as a reminder to self (and in case I forget to do it).

Oh, hmm, this may actually be 'correct' (though I'm still surprised that the list of applicable policies doesn't include the remoterule one). In the package's gating.yaml, gating is only configured for bodhi_update_push_stable, not bodhi_update_push_testing.

The result of this at the Bodhi web UI level I would call kinda surprising, but that's an issue in Bodhi rather than greenwave, I guess. We maybe need to make Bodhi more sophisticated about considering the two different gating points - it's still important/useful to know whether the update is gated from stable push even before it reaches testing, and what test cases are required at that point.

A matching policy containing just a RemoteRule would not be listed in applicable_policies if the subject's gating.yaml itself does not contain any matching policy.

I think it is due to this line: https://github.com/release-engineering/greenwave/blob/6afad9ffff9480b0aabffbc0462445b2238cb46c/greenwave/policies.py#L676

I can see that it can be confusing and I don't see any strong reason for not listing the policy. So would it be better for Greenwave to always list such policy?

yeah...I kinda feel like it would. to me, anyway. I kinda read that list as a list of the policies that are applicable at the level of the greenwave app's configuration.

The fix is here: https://github.com/release-engineering/greenwave/pull/184

@adamwill Please help us review the change.

Metadata Update from @lholecek:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.