#640 Greenwave returning 'test-result-missing' when it clearly isn't
Closed: Fixed 2 years ago by adamwill. Opened 2 years ago by adamwill.

This is affecting production Greenwave ATM so it is an urgent issue, and I can't see why it's happening.

Greenwave currently believes every critpath update is failing the bodhi_update_push_stable_critpath decision context. It says several results are missing. But the verbose output of the same request shows clearly that the result is not missing. For e.g., if you run this query:

echo '{"product_version":"fedora-33","decision_context":"bodhi_update_push_stable_critpath","subject":[{"item":"nss-3.65.0-1.fc33","type":"koji_build"},{"item":"FEDORA-2021-85149db388","type":"bodhi_update"}],"verbose":true}' | http post https://greenwave.fedoraproject.org/api/v1.0/decision

You get a result claiming "21 of 49 required test results missing", but the "missing" results are clearly shown in the forwarded ResultsDB set. For e.g., the results section contains this result:

    {
        "data": {
            "arch": [
                "x86_64"
            ],
            "firmware": [
                "bios"
            ],
            "item": [
                "FEDORA-2021-85149db388"
            ],
            "meta.conventions": [
                "result fedora.bodhi"
            ],
            "scenario": [
                "fedora.updates-everything-boot-iso.x86_64.64bit"
            ],
            "source": [
                "openqa"
            ],
            "type": [
                "bodhi_update"
            ]
        },
        "groups": [
            "0f3309ea-6d4c-59b2-b422-d73e9b8511f3",
            "b6a7b6e0-08a1-5c87-b5a5-0e8c75ffe86e",
            "df76b0bc-e22f-56e4-a85c-9b754400e909"
        ],
        "href": "https://taskotron.fedoraproject.org/resultsdb_api/api/v2.0/results/39756362",
        "id": 39756362,
        "note": "",
        "outcome": "PASSED",
        "ref_url": "https://openqa.fedoraproject.org/tests/899539",
        "submit_time": "2021-05-31T04:04:59.949408",
        "testcase": {
            "href": "https://taskotron.fedoraproject.org/resultsdb_api/api/v2.0/testcases/update.install_default_update_netinst",
            "name": "update.install_default_update_netinst",
            "ref_url": "https://openqa.fedoraproject.org/tests/904531"
        }
    },

but the decision section lists it as 'missing':

    {
        "item": {
            "item": "FEDORA-2021-85149db388",
            "type": "bodhi_update"
        },
        "scenario": "fedora.updates-everything-boot-iso.x86_64.64bit",
        "subject_identifier": "FEDORA-2021-85149db388",
        "subject_type": "bodhi_update",
        "testcase": "update.install_default_update_netinst",
        "type": "test-result-missing"
    },

I don't know exactly when this started and I don't know what's causing it, but it's obviously a big problem...


staging is not returning the same thing (it reports "1 of 50 required tests failed" , with the failed test being the CI test failed-fetch-gating-yaml). So this may be some kind of caching issue, I guess. But we just restarted prod greenwave and it's still doing the same thing. Where does the "external cache" live?

Huh: this only happens when passing verbose=true in the request. With verbose=false I get "All required tests passed". I feel like I actually fixed a bug like this before...

Yeah, I believe https://pagure.io/greenwave/pull-request/613 fixed a bug a lot like this. Are we somehow suddenly running a really old greenwave in prod or something? This is good in a way because I think the actual gating decisions for Bodhi run off non-verbose requests, so they'll be correct. But the user-visible info on the web UI is based on a verbose request, so it shows the "missing" tests, which will confuse people.

I'm not sure what happened but maybe the release got reverted in fedora: https://greenwave.fedoraproject.org/api/v1.0/about

We had some issue internally and had to release a quickfix.

Let me try to fix that.

Released "1.8.1.dev1+git.f82e887" (the same version we use internally in prod): https://greenwave.fedoraproject.org/api/v1.0/about

Sorry, about the mess.

thanks! It does seem to have solved the problem.

Metadata Update from @adamwill:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

2 years ago

Login to comment on this ticket.

Metadata