#431 Check that greenwave RemoteRule works in a world without cgit
Closed: Invalid 4 years ago by gnaponie. Opened 4 years ago by ralph.

cgit is going away! The infra team is adding some redirects here: https://pagure.io/fedora-infrastructure/issue/7736

Can someone verify that greenwave RemoteRule will still work?


The redirects would need to work with the cgit template Greenwave uses:

{DIST_GIT_BASE_URL}cgit/{pkg_namespace}/{pkg_name}/plain/gating.yaml?id={rev}

Greenwave could use the "git archive" method (by changing the base URL to "git://...") but there were some issues (unexpected git errors) with this approach and the change was reverted in our openshift-templates repo.

The fix for the issue lholecek mentioned is planned and should be resolved quite soon, so we might switch to it.
But we didn't plan to use that in Fedora, because as far as I know it's not possible.
@mprahl can provide move information about it I believe.

Can't we just change the conf to point to the new one?

Oh, for Fedora the URL template is:

{DIST_GIT_BASE_URL}/{pkg_namespace}/{pkg_name}/raw/{rev}/f/gating.yaml

Is that OK?

If there are redirects, I think current code should handle it correctly.

The fix for the issue lholecek mentioned is planned and should be resolved quite soon, so we might switch to it.
But we didn't plan to use that in Fedora, because as far as I know it's not possible.
@mprahl can provide move information about it I believe.
Can't we just change the conf to point to the new one?

Yes, the git servers in Fedora infra don't support git archive, so we have to keep using HTTP requests. Pagure should update content in real time, unlike cgit, so it's not really an issue.

Oh, for Fedora the URL template is:
{DIST_GIT_BASE_URL}/{pkg_namespace}/{pkg_name}/raw/{rev}/f/gating.yaml

Is that OK?
If there are redirects, I think current code should handle it correctly.

Don't we still want to change it? They wrote that they'll try to keep the redirects, but they'll be only simple ones with no guarantee they'll work forever.

Don't we still want to change it? They wrote that they'll try to keep the redirects, but they'll be only simple ones with no guarantee they'll work forever.

I'm not sure if that URL needs redirect -- it does not contain cgit component.

@gnaponie, @lholecek: The URL that Greenwave is using in Fedora is the Pagure URL, not cgit. So this is not an issue, as Pagure will remain working.

Oh, ok. Great. So I guess we can close this out.
Thank you everyone for the feedback and @ralph for informing us.

Metadata Update from @gnaponie:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata