Learn more about these different git repos.
Other Git URLs
Currently the accepted subject_type(s) are hard-coded inside Greenwave. It would be nice to have the list of possible subject types in the conf, so that we can add easily new subject types, even someone that is not familiar with the code-base.
For example look in the code for "component-version".
+1 As more and more projects and teams are using Greenwave, I can foresee there will be more subject_types. It will be nice to have this flexibility!
Alternatively, GW could accept any subject_type value.
subject_type
We could. Is there any downside in that? mmm nothing comes into my mind.
Well, I though GW might give some good warning for an unknown subject_type value. But before any such check can kick in, it tries to find applicable policies. E.g. using subject_type==koji-build (easy typo to use dash instead of underscore) will result in Cannot find any applicable policies for koji-build subjects ...
subject_type==koji-build
Cannot find any applicable policies for koji-build subjects ...
So no idea about the downsides now.
Metadata Update from @gnaponie: - Issue assigned to gnaponie
Metadata Update from @gnaponie: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Login to comment on this ticket.