greenwave

#332 Support for making a decision whether to merge a pull-request or not
Closed: Fixed by gnaponie. Opened by rayson.

Closed: Fixed
Reopen Issue

As a part of the effort of integrating continuous integration/continuous delivery pipelines with Factory 2.0, we'd like to let Greenwave to make a decision whether a pull-request is good to merge based on policies and test results. Possible workflow:

  1. A user files a pull-request in Pagure/Gerrit/Github/Gitlab.
  2. The CI/CD pipelines build the pull-request. Unit tests, linters, and integration tests are run.
  3. The CI/CD pipelines send results of all tests to ResultsDB
  4. Greenwave sends a message to indicate if criteria if criteria for merging the change (successful test results) have been met.
  5. CI/CD pipelines continue to the next step according to the decision made by Greenwave.

This may require a new subject_type and certain data provided by Result objects.

CC @gnaponie @lholecek @ralph @lucarval

Sounds good to me

Would the PR be automatically merged in this case? I'm hoping not. In some cases tests may pass just fine, but humans may have objections to approach, styles, etc.

Otherwise, yes, I think it would be very useful to have these tests happen automatically.

@lucarval No. It just sets a flag to indicate whether it is safe to merge. Merging or not is still decided by humans.
Edited by rayson

Hi, pull requests for new artifact types container-image and pull-request have been merged into the fedora-ci/messages repo (https://pagure.io/fedora-ci/messages/pull-request/18, https://pagure.io/fedora-ci/messages/pull-request/16). Can anyone take the task of supporting those new artifacts from the message bus?

Metadata Update from @gnaponie:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.