The cockpit package is listed in the package for which we want results from the AtomicCI pipeline to pass, but looking at: https://bodhi.fedoraproject.org/updates/FEDORA-2018-ecee722a34 it says that Tests Passed but I found out that the pipeline ignored that commit: https://apps.fedoraproject.org/datagrepper/id?id=2018-7947c931-b5ac-476c-a238-3889783cc520&is_raw=true&size=extra-large
Tests Passed
And there was no pipeline.complete message for it (that I could find in: https://apps.fedoraproject.org/datagrepper/raw?topic=org.centos.prod.ci.pipeline.complete )
pipeline.complete
So do we have a bug somewhere?
looks like atomic_ci_pipeline_results (the greenwave policy) is only enabled for fedora-26.
atomic_ci_pipeline_results
fedora-26
Is it time to expand that? Do you have rights to do it @pingou?
To update the config and run the playbook yes, but I guess it'll need a FBR.
That does explain the behavior though :-p
Ok, @stefw found two f26 bodhi updates that failed the Atomic CI pipeline but haven't been gated: - https://bodhi.fedoraproject.org/updates/FEDORA-2018-66c96e0024 - https://bodhi.fedoraproject.org/updates/FEDORA-2018-85dd2a6ff9
I went through the waivers and didn't see a waiver about Atomic CI, so the results didn't get waived.
Any ideas?
Try running this script:
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29
#!/usr/bin/env python """ Ask a question of greenwave. """ import pprint import sys import requests nvr = 'curl-7.53.1-16.fc26' url = ( 'https://greenwave-web-greenwave.app.os.fedoraproject.org/' 'api/v1.0/decision') for context in ['bodhi_update_push_testing', 'bodhi_update_push_stable']: payload = dict( decision_context=context, product_version='fedora-26', subject=[ {'item': nvr, 'type': 'koji_build'}, {'original_spec_nvr': nvr}, ], # This gets you all the passing results as well as the failing ones #verbose=True, ) response = requests.post(url, json=payload, verify=False) print("-" * 40) print(context) print(nvr, response, response.status_code) data = response.json() print(pprint.pformat(data))
It shows that greenwave says "no" to letting that curl build go to testing, but it says "yes" to letting it go to stable.
This is because we have the atomic ci rule listed only for testing in the greenwave policy server side. I'll fix that right away.
What is still unexplained is why Bodhi let the update go to testing in the first place.
Well... I guess we're in freeze, so I'll change the policy only after it thaws next week. Will file an infra unfreeze ticket to track it.
See fedora-infrastructure#6806.
Going to close this in favor of the infra ticket.
Metadata Update from @ralph: - Issue status updated to: Closed (was: Open)