Learn more about these different git repos.
Other Git URLs
Currently, greenwave returns unsatisfied requirements to a caller.
For Bodhi UI usage (and ET usage), greenwave might as well also return the list of satisfied requirements.
While we're at it, greenwave should return a third list of extraneous_results. These are results that resultsdb has, but which do not apply to any of the greenwave policies in play. Bodhi or ET may want to display these to users.
Metadata Update from @ralph: - Issue assigned to ralph
Ah, this is done now! Just pass verbose=True to the query and you should get back the full list of results in one list and the full list of waivers in another.
verbose=True
Done in #125.
OK, @mvadkert re-raised this one. He really does need the list of satisfied_requirements to be returned.
Metadata Update from @lholecek: - Issue assigned to lholecek (was: ralph)
@mvadkert Can you provide more info?
Are "satisfied requirements" always needed? This could be toggled by verbose flag or new flag.
verbose
What details should be provided in satisfied requirements? Apart from item, testcase and scenario (as provided in unsatisfied_requirements), I'm thinking about adding "type" to know if an item was blacklisted in policies, missing test result was waived etc.
item
testcase
scenario
unsatisfied_requirements
@lholecek trying to provide more information:
For consistency, I would like to have them available always, same as the unsatisfied requirements. But I do not insist on it if you do not strongly agree, just please do not use a new flag, I think verbose is sufficient.
Right, all fields from unsatisfied_requirements is a must. Type would be very nice, indeed, if you could include it, it would be awesome.
Another thing that bugs me is that I currently need to iterate through the "results" field to find the details of the resultsdb result. Thus if we could also include the results directly in the satisfied requirements (if available or make sense) that would be super awesome. The same applies for unsatisfied requirements which have results or waivers available. But this change could be another RFE.
@mvadkert, pls review the PR #207 when you have the time.
Metadata Update from @lholecek: - Issue close_status updated to: Fixed - Issue set to the milestone: 0.8 - Issue status updated to: Closed (was: Open) - Issue tagged with: enhancement
Metadata Update from @lholecek: - Issue untagged with: enhancement - Issue tagged with: feature
Login to comment on this ticket.